Old blog (/blogs/...) paths are broken #125

Closed
opened 2018-12-18 04:25:22 +00:00 by mlncn · 19 comments
mlncn commented 2018-12-18 04:25:22 +00:00 (Migrated from gitlab.com)

For example:

Need to be redirected to:

respectively.

@cedewey could you:

  • Review other paths to see if they are also broken.
  • Confirm that only the blogs to blog portion needs to change in every case. (My fear is that as it appears the path did not get migrated, or paths were regenerated without redirects being created, and so some small difference in the rule for making the path, such as which special characters get replaced or short words get skipped, could mean most paths match but a few break. David may have a faster way of checking than manually.)
  • Automatically or manually come up with the redirects and/or redirect rules needed and assign to @cedewey to add them.
For example: * https://agaric-live-test.drutopia.org/blogs/creating-new-social-simple-button * https://agaric-live-test.drutopia.org/blogs/marking-drupals-blog-posts-indieweb Need to be redirected to: * https://agaric-live-test.drutopia.org/blog/creating-new-social-simple-button * https://agaric-live-test.drutopia.org/blog/marking-drupals-blog-posts-indieweb respectively. @cedewey could you: * [x] Review other paths to see if they are also broken. * [x] Confirm that only the `blogs` to `blog` portion needs to change in every case. (My fear is that as it appears the path did not get migrated, or paths were regenerated without redirects being created, and so some small difference in the rule for making the path, such as which special characters get replaced or short words get skipped, could mean most paths match but a few break. David may have a faster way of checking than manually.) * [x] Automatically or manually come up with the redirects and/or redirect rules needed and assign to @cedewey to add them.
cedewey commented 2018-12-18 17:45:27 +00:00 (Migrated from gitlab.com)

marked the checklist item Review other paths to see if they are also broken. as completed

marked the checklist item **Review other paths to see if they are also broken.** as completed
cedewey commented 2018-12-18 17:48:10 +00:00 (Migrated from gitlab.com)

@mlncn I've checked non-blog-post pages and they paths work as expected.

@mlncn @gnuget I've checked a handful of blog posts and they all use /blogs/[title] I'm confident they're all following this path structure.

@gnuget can you set a redirect rule for all the blog posts from the old site that use /blogs/[title] to the new path /blog/[title]?

@mlncn I've checked non-blog-post pages and they paths work as expected. @mlncn @gnuget I've checked a handful of blog posts and they all use /blogs/[title] I'm confident they're all following this path structure. @gnuget can you set a redirect rule for all the blog posts from the old site that use /blogs/[title] to the new path /blog/[title]?
cedewey commented 2018-12-18 17:48:14 +00:00 (Migrated from gitlab.com)

assigned to @gnuget and unassigned @cedewey

assigned to @gnuget and unassigned @cedewey
mlncn commented 2018-12-18 22:22:42 +00:00 (Migrated from gitlab.com)

assigned to @wolcen and unassigned @gnuget

assigned to @wolcen and unassigned @gnuget
mlncn commented 2018-12-18 22:23:47 +00:00 (Migrated from gitlab.com)

I tagged @cedewey when i meant @wolcen

Chris can you add the redirect rule?

Clayton, Chris has been handling that part.

I tagged @cedewey when i meant @wolcen Chris can you add the redirect rule? Clayton, Chris has been handling that part.
wolcen commented 2018-12-20 03:56:35 +00:00 (Migrated from gitlab.com)

marked the checklist item Automatically or manually come up with the redirects and/or redirect rules needed and assign to @cedewey to add them. as completed

marked the checklist item **Automatically or manually come up with the redirects and/or redirect rules needed and assign to @cedewey to add them.** as completed
wolcen commented 2018-12-20 04:05:18 +00:00 (Migrated from gitlab.com)

Assuming that all blogs/* -> blog/$1, the capability to modify htaccess per-site now exists in drutopia_hosting, and the settings for agaric sites is added. Subsequent deploy of the site will install the rules.

  • Update of htaccess tested in drutopia deploy locally
  • htaccess rule itself tested in agaric-com.test

Note, this does not redirect blogs -> blog (i.e. w/out a blog title). If needed, just add an additional rule to the config for this. In drutopia_host/hosting_private/): ahoy vault-edit and within the agaric_test and agaric_live settings, update the setting:

  htaccess_mod: |1+
    RewriteRule ^blogs/(.*)$ /blog/$1 [L,R=301]
    RewriteRule ^blogs$ /blog [L,R=301]
Assuming that all blogs/* -> blog/$1, the capability to modify htaccess per-site now exists in drutopia_hosting, and the settings for agaric sites is added. Subsequent deploy of the site will install the rules. - [X] Update of htaccess tested in drutopia deploy locally - [X] htaccess rule itself tested in agaric-com.test Note, this does not redirect blogs -> blog (i.e. w/out a blog title). If needed, just add an additional rule to the config for this. In drutopia_host/hosting_private/): `ahoy vault-edit` and within the agaric_test and agaric_live settings, update the setting: ``` htaccess_mod: |1+ RewriteRule ^blogs/(.*)$ /blog/$1 [L,R=301] RewriteRule ^blogs$ /blog [L,R=301] ```
mlncn commented 2018-12-20 16:41:11 +00:00 (Migrated from gitlab.com)

mentioned in issue #131

mentioned in issue #131
mlncn commented 2018-12-20 16:48:37 +00:00 (Migrated from gitlab.com)

mentioned in issue #126

mentioned in issue #126
cedewey commented 2018-12-20 17:17:11 +00:00 (Migrated from gitlab.com)

assigned to @mlncn and unassigned @wolcen

assigned to @mlncn and unassigned @wolcen
cedewey commented 2018-12-20 17:17:44 +00:00 (Migrated from gitlab.com)

Thanks @wolcen !

Assigning to @mlncn to check that rewrites worked as expected after deploying.

Thanks @wolcen ! Assigning to @mlncn to check that rewrites worked as expected after deploying.
mlncn commented 2018-12-20 22:47:35 +00:00 (Migrated from gitlab.com)

@cedewey Deployed and back to you :-)

@cedewey Deployed and back to you :-)
mlncn commented 2018-12-20 22:47:45 +00:00 (Migrated from gitlab.com)

assigned to @cedewey and unassigned @mlncn

assigned to @cedewey and unassigned @mlncn
cedewey commented 2018-12-21 00:09:03 +00:00 (Migrated from gitlab.com)

@wolcen @mlncn

Redirects didn't work. :'( Example - https://agaric-live-test.drutopia.org/blogs/barcamp9-boston-what-trip

Assigning back to @wolcen

@wolcen @mlncn Redirects didn't work. :'( Example - https://agaric-live-test.drutopia.org/blogs/barcamp9-boston-what-trip Assigning back to @wolcen
cedewey commented 2018-12-21 00:09:09 +00:00 (Migrated from gitlab.com)

assigned to @wolcen and unassigned @cedewey

assigned to @wolcen and unassigned @cedewey
wolcen commented 2018-12-21 17:03:23 +00:00 (Migrated from gitlab.com)

@mlncn did you pull drutopia_hosting AND hosting_private prior to pushing (I don't see the RewriteRule being written)? I don't see your deploy record, but it occurs to me that it would be nice if I also record the version of the hosting scripts that perform a deploy.

@mlncn did you pull drutopia_hosting AND hosting_private prior to pushing (I don't see the RewriteRule being written)? I don't see your deploy record, but it occurs to me that it would be nice if I also record the version of the hosting scripts that perform a deploy.
cedewey commented 2018-12-26 18:49:58 +00:00 (Migrated from gitlab.com)

marked the checklist item Confirm that only the blogs to blog portion needs to change in every case. (My fear is that as it appears the path did not get migrated, or paths were regenerated without redirects being created, and so some small difference in the rule for making the path, such as which special characters get replaced or short words get skipped, could mean most paths match but a few break. David may have a faster way of checking than manually.) as completed

marked the checklist item **Confirm that only the `blogs` to `blog` portion needs to change in every case. (My fear is that as it appears the path did not get migrated, or paths were regenerated without redirects being created, and so some small difference in the rule for making the path, such as which special characters get replaced or short words get skipped, could mean most paths match but a few break. David may have a faster way of checking than manually.)** as completed
cedewey commented 2018-12-26 18:50:09 +00:00 (Migrated from gitlab.com)

Redirects are now working as expected. yahoo!

Redirects are now working as expected. yahoo!
cedewey commented 2018-12-26 18:50:10 +00:00 (Migrated from gitlab.com)

closed

closed
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: agaric/agaric-coop#125
No description provided.