Restore Drupal Planet feed #159
Labels
No labels
A11y
Automated Testing
Contributable
Contributed
Decision
Design
Development
Drutopia
Feature Request
IndieWeb
Infrastructure
Marketing
Needs documentation
status::Abandoned
status::Blocked
status::Deploy
status::Doing
status::Done
status::In Review
status::Needs Clarification
status::Test
status::To Do
type::Bug
type::Task
type::User Story
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: agaric/agaric-coop#159
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Our Drupal planet feed used to come from https://agaric.com/taxonomy/term/5/feed but now comes from https://agaric.coop/taxonomy/term/36/feed
We also need to add the summary of articles to the feed.
Work Required
debug: falsechanged the description
mentioned in merge request !45
marked this issue as related to #56
Given that our worker-owner person content got shoved to the very top of the Drupal Planet feed, with display problems, after this merge request went in, we need to do some work on the RSS XML output and formatting in addition to getting the RSS feed Drupal Planet looks for updated to our alias.
From checking out the source of other feeds:
<title>should be plain text, not a link.<pubDate>should be formatted something likeMon, 24 Dec 2018 10:52:14 +0100rather than2019 January 02<dc:creator>should also probably not be a link, and may be easier to just set to agaric.coop for nowAlso the description of the entire feed (
<description>Drupal related posts by the Agaric tech cooperative.</description>) shouldn't be the same for all terms.mentioned in merge request !46
assigned to @mlncn and unassigned @cedewey
Assigned to @mlncn to complete the reconfiguring of our RSS feeds.
TLDR: Translation capability made the taxonomy term listings (including feeds and the planet feed) become empty, unless the translation language constraint is removed.
The thing that was 'breaking', that was really making it difficult for me to continue styling the feed, was after the translation stuff was working (despite the red herrings of configuration import failures), it caused the existing condition on the taxonomy term view (including feeds) - "Content: Translation language (= Content language selected for page)" - to make nothing show up.
@gnuget (this part may have been cut off from the IRC message)
Maybe worth another blog post? Taxonomy term listings and feeds should be multilingual by default for sites doing 'best effort' translation, but the default configuration assumes complete translation basically, so only showing contet that has a selected language. At least i think that's what's happening?
Something similar happened to me, if the blog post language value is "und" it won't allow to translated the node (the
translatetab is hidden), it needs to be "en" in order to see the option to translate the node.mentioned in commit
1d3b9cd2eb@gnuget Should we be bulk-updating all nodes then? An update hook will work for this! (Also, we're pulling into the park now!)
mentioned in commit
0459585965So i'd very much prefer not to just cut off at a certain number of characters or words. We consider our Summary field much to short for the purpose. Paragraphs module has done a lot to provide administrative summaries but there's only a long-out-of-date patch seeking to provide a paragraph summary formatter sufficient for visitor-facing teasers.
@cedewey How do you feel about making the first text paragraph our RSS feed 'description'? Some blog posts might need to have their text paragraph split but i think this approach provides a good balance between control and complexity (especially given the lack of other options).
mentioned in commit
93a85a8d6bSure, that seems fine, at least for the time being. We should add some
help text to make this clear to authors. I'll do that.
mentioned in commit
7184d9cfc3marked the checklist item Update the feed with the summary and provide a friendly alias like /drupal-planet-feed as completed
marked the checklist item Post issue in Drupal Planet queue to have RSS feed changed as completed
There is a link on the bottom of this page: https://www.drupal.org/node/230418/revisions/view/3437513/11215911 that leads to a 404 resolving here https://agaric.coop/keywords/drupal-planet
@mlncn @wolcen
changed the description
[apologies never hit submit on this comment some days ago]
@cedewey so where it stands now is after deployment, the 'drupal-planet' alias needs to be changed from 'taxonomy/term/36/feed' to 'taxonomy/term/36/teasers/feed'
The feed that should be tested therefore is /taxonomy/term/36/teasers/feed
Note that this will not parse locally unless services.yml is changed to twig debug: false
assigned to @gnuget and unassigned @mlncn
marked the checklist item Update markup to properly render posts in RSS readers as completed
@gnuget if you can deploy this to the test site, I can then change the
/drupal-planetalias and test it.assigned to @cedewey and unassigned @gnuget
@gnuget @mlncn ,
Looking good! The one thing remaining I can see is that the word "text" is showing up at the beginning of the description each time.
assigned to @gnuget and unassigned @cedewey
changed the description
changed the description
marked the checklist item Remove the word "text" in the description as completed
I just deployed this in production
I'm keeping this open with the ~Deploy tag until we are certain this is working properly because right now it is not. As part of the deployment process the path needed to be updated for /drupal-planet. I've done this, but the planet hasn't updated its feed since we made that change.
I'm now going back through recent Drupal Planet tagged posts and setting the teaser text by breaking up the intended teaser text into its own text paragraph.
In the future, whoever deploys needs to read the issue description carefully, especially the Work Required section and make sure every step is completed.
marked the checklist item Change 'drupal-planet' alias from 'taxonomy/term/36/feed' to 'taxonomy/term/36/teasers/feed' as completed
marked the checklist item Test as completed
marked the checklist item Update Drupal Planet posts to use two Text Paragraphs - cutting off the summary wherever seems appropriate. as completed
marked the checklist item Deploy as completed
changed the description
Yes, the right thing to do was write a hook_update to make this change automatically in the deploy.
My bad, next time I will do it.
And it seems that the bad links are going to be preserved until new blog posts make them disappear, so... would it be a good idea to publish our blog posts to help that to happen faster?
This has been working for a few weeks now, I'm going to close this.
closed