agaric/agaric-coop
10
1
Fork 0
Code Issues 102 Pull requests Projects Releases Packages Wiki Activity

prismjs highlighted code numbers look bad #204

New issue
Open
opened 2019-06-06 15:42:38 +00:00 by gnuget · 7 comments
gnuget commented 2019-06-06 15:42:38 +00:00 (Migrated from gitlab.com)
Copy link

It seems that we have a number class on our site which is used by prism as well making it look weird.

It is necessary to add CSS to avoid apply styles to the number class if it is inside a code tag.

Screen_Shot_2019-06-06_at_10.41.12_AM

It seems that we have a `number` class on our site which is used by `prism` as well making it look weird. It is necessary to add CSS to avoid apply styles to the `number` class if it is inside a `code` tag. ![Screen_Shot_2019-06-06_at_10.41.12_AM](/uploads/9ccebff63af8ce213a2b66e9295979f8/Screen_Shot_2019-06-06_at_10.41.12_AM.png)
gnuget commented 2019-06-06 15:43:22 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
mlncn commented 2019-06-06 15:44:13 +00:00 (Migrated from gitlab.com)
Copy link

'number' does not appear in our custom Sass (web/themes/custom/agarica/patternlibrary/agaric/sass/). So our first step is figuring out where it's coming from.

'number' does not appear in our custom Sass (web/themes/custom/agarica/patternlibrary/agaric/sass/). So our first step is figuring out where it's coming from.
mlncn commented 2019-06-06 15:44:53 +00:00 (Migrated from gitlab.com)
Copy link

@gnuget Bulma is to blame! node_modules/bulma/sass/elements/other.sass

@gnuget Bulma is to blame! `node_modules/bulma/sass/elements/other.sass`
mlncn commented 2019-06-06 15:49:58 +00:00 (Migrated from gitlab.com)
Copy link

@gnuget Can we avoid using the number class ourselves by telling prism to do something else, and leave 'number' to bulma?

Or vice versa.

A-hmm: https://github.com/jgthms/bulma/issues/1708

@gnuget Can we avoid using the number class ourselves by telling prism to do something else, and leave 'number' to bulma? Or vice versa. A-hmm: https://github.com/jgthms/bulma/issues/1708
mlncn commented 2019-06-06 15:53:13 +00:00 (Migrated from gitlab.com)
Copy link

Seems it can be fixed either way; i'm helping Mauricio train so leaving this to David.

Seems it can be fixed either way; i'm helping Mauricio train so leaving this to David.
mlncn commented 2019-06-06 15:53:13 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @gnuget

assigned to @gnuget
cedewey commented 2020-04-13 14:44:42 +00:00 (Migrated from gitlab.com)
Copy link

unassigned @gnuget

unassigned @gnuget
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
bbb-test
D9-upgrade
drush-9-aliases
provision-dewey
No results found.
Labels
Clear labels   
A11y

Accessibility-related issues

  
Automated Testing

   
Contributable

Issues with work that can (potentially) be contributed back to Drupal or other FLOSS projects.

  
Contributed

Tag issues where we have contributed work back to FLOSS projects (replace Contributable tag; the Contributed tag can be removed once the contribution is recorded in a blog or something.

  
Decision

An issue that requires a decision be made.

  
Design

Issues that should include a UX/design work or review.

  
Development

   
Drutopia

Issues related to Drutopia features or infrastructure, or are potential Drutopia enhancements (with tag Contributable).

  
Feature Request

   
IndieWeb

Anything related to interlinking web sites in a broadly IndieWeb fashion, see https://indieweb.org/

  
Infrastructure

   
Marketing

   
Needs documentation

When an issue has uncovered something that should be documented in a user guide or the project wiki or anywhere else outside the issue queue.

  
status::Abandoned

An issue that has been abandoned and will not be completed.

  
status::Blocked

An issue that is blocked for a reason outside Agaric's control.

  
status::Deploy

An issue that has been tested and is ready to be deployed.

  
status::Doing

   
status::Done

   
status::In Review

An issue that has been completed and is ready for a code and/or design review.

  
status::Needs Clarification

   
status::Test

An issue that has been completed and is ready to be tested.

  
status::To Do

An issue that is an agreed priority and has all information needed to be completed.

  
type::Bug

   
type::Task

   
type::User Story
No labels
A11y
Automated Testing
Contributable
Contributed
Decision
Design
Development
Drutopia
Feature Request
IndieWeb
Infrastructure
Marketing
Needs documentation
status::Abandoned
status::Blocked
status::Deploy
status::Doing
status::Done
status::In Review
status::Needs Clarification
status::Test
status::To Do
type::Bug
type::Task
type::User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: agaric/agaric-coop#204
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?