agaric/agaric-coop
10
1
Fork 0
Code Issues 102 Pull requests Projects Releases Packages Wiki Activity

A visitor can comment on a blog post. #32

New issue
Closed
opened 2017-12-15 21:45:35 +00:00 by cedewey · 34 comments
cedewey commented 2017-12-15 21:45:35 +00:00 (Migrated from gitlab.com)
Copy link

Acceptance Criteria

Given that I am a visitor
when I view a blog post
then I can leave a comment.

Notes

Outstanding Questions

  • Who should have permission to leave a comment? Can anonymous users comment?

Work Required

  • Enable commenting on blog posts (don't require account creation/login)
## Acceptance Criteria Given that I am a visitor when I view a blog post then I can leave a comment. ## Notes * [Blog Post Wireframe](https://marvelapp.com/5c327g8/screen/36342186) * Comments are threaded. ## Outstanding Questions * [x] Who should have permission to leave a comment? Can anonymous users comment? ## Work Required * [ ] Enable commenting on blog posts (don't require account creation/login)
cedewey commented 2017-12-15 21:45:50 +00:00 (Migrated from gitlab.com)
Copy link

added ~3181995 label

added ~3181995 label
cedewey commented 2017-12-15 21:45:57 +00:00 (Migrated from gitlab.com)
Copy link

added ~2741822 label

added ~2741822 label
cedewey commented 2017-12-15 21:47:49 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
cedewey commented 2018-01-24 20:54:22 +00:00 (Migrated from gitlab.com)
Copy link

added ~3378865 label

added ~3378865 label
cedewey commented 2018-01-24 21:07:50 +00:00 (Migrated from gitlab.com)
Copy link

changed milestone to %4

changed milestone to %4
cedewey commented 2018-01-24 21:18:29 +00:00 (Migrated from gitlab.com)
Copy link

added ~3378960 label

added ~3378960 label
cedewey commented 2018-09-26 16:19:29 +00:00 (Migrated from gitlab.com)
Copy link

changed milestone to %3

changed milestone to %3
cedewey commented 2018-09-26 16:19:29 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @mlncn

assigned to @mlncn
cedewey commented 2018-11-28 19:30:31 +00:00 (Migrated from gitlab.com)
Copy link

changed milestone to %7

changed milestone to %7
cedewey commented 2018-12-13 16:22:09 +00:00 (Migrated from gitlab.com)
Copy link

I think anonymous users should be able to comment, but that those be moderated. If there aren't any objections we'll move forward in this way.

I think anonymous users should be able to comment, but that those be moderated. If there aren't any objections we'll move forward in this way.
mlncn commented 2018-12-18 03:07:43 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey Do we allow people to register, or make them comment anonymously?

And @wolcen or @FreeScholar or anyone want to suggest an #indieweb module we can throw in last minute, to also encourage / acknowledge comments of that kind?

Dries Buytaert is presumably using something; i don't remember if the article says: https://dri.es/to-pesos-or-to-posse

Ah man searching for Dries' blog posts reminds me we have a bit more of a reputation to maintain in the IndieWeb world:

https://indieweb.org/Drupal

(i did not try to take credit for Agaric in my name... hadn't seen this... anyhow Stefan led the effort at making Agaric's site as IndieWeb as it got)

@cedewey Do we allow people to register, or make them comment anonymously? And @wolcen or @FreeScholar or anyone want to suggest an #indieweb module we can throw in last minute, to also encourage / acknowledge comments of that kind? Dries Buytaert is presumably using something; i don't remember if the article says: https://dri.es/to-pesos-or-to-posse Ah man searching for Dries' blog posts reminds me we have a bit more of a reputation to maintain in the IndieWeb world: https://indieweb.org/Drupal (i did not try to take credit for Agaric in my name... hadn't seen this... anyhow Stefan led the effort at making Agaric's site as IndieWeb as it got)
cedewey commented 2018-12-18 17:51:32 +00:00 (Migrated from gitlab.com)
Copy link

@mlncn we could install and configure the IndieWeb module - https://www.drupal.org/project/indieweb

@mlncn I think we should allow people to register, but also allow them to comment anonymously. Anonymous comments though should first be approved before published.

@mlncn we could install and configure the IndieWeb module - https://www.drupal.org/project/indieweb @mlncn I think we should allow people to register, but also allow them to comment anonymously. Anonymous comments though should first be approved before published.
mlncn commented 2018-12-19 00:36:17 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 89f53a718a

mentioned in commit 89f53a718aebc2895801beced94db6719e8dcdec
mlncn commented 2018-12-19 00:36:17 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 23011d02ae

mentioned in commit 23011d02ae705b8285dca8b5b4bf90c9a2317946
FreeScholar commented 2018-12-23 05:42:39 +00:00 (Migrated from gitlab.com)
Copy link

Anon - but must be approved

Anon - but must be approved
mlncn commented 2018-12-25 02:18:43 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit ea1f71ca3e

mentioned in commit ea1f71ca3e643e67396ee55a0f648c219d562423
mlncn commented 2018-12-25 16:48:26 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit be8c428d84

mentioned in commit be8c428d84bf7b434e61a44c49e1155e842746ce
mlncn commented 2018-12-26 02:10:41 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit b584a8824a

mentioned in commit b584a8824a8b5a2b45cc8cc7beceb9e3dbd73577
mlncn commented 2018-12-26 04:29:31 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 98a4873d2d

mentioned in commit 98a4873d2d08be8771b3dddbe963ff9068067a4a
mlncn commented 2018-12-26 15:08:57 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 2380ca8a57

mentioned in commit 2380ca8a5720cc3039d7185277b55bfaac7235d4
mlncn commented 2018-12-26 17:09:55 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 76075b5fb5

mentioned in commit 76075b5fb558d880ce44adbc0ec3a337d4d6fcb2
mlncn commented 2018-12-27 01:46:45 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 475b45ccb1

mentioned in commit 475b45ccb1b01282e30e1c1fdf28924223cd24c3
mlncn commented 2018-12-27 02:11:23 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 4901a5e7d1

mentioned in commit 4901a5e7d1d1bd3826413f2d3665736c7f42c38b
cedewey commented 2018-12-27 02:32:57 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item Who should have permission to leave a comment? Can anonymous users comment? as completed

marked the checklist item **Who should have permission to leave a comment? Can anonymous users comment?** as completed
mlncn commented 2018-12-27 03:00:09 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit f339497fa3

mentioned in commit f339497fa3b42d0c6328c90f88ddae86617ba0f0
mlncn commented 2018-12-27 06:40:25 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey i will close this, but the potential followups are:

  • Providing a nicer message about awaiting comment approval by overriding the text from web/core/modules/comment/src/CommentForm.php line 388, 'Your comment has been queued for review by site administrators and will be published after approval.', by putting a string override in provisioning/drutopia/roles/drupal/templates/settings.local.php.j2 - #138
  • Marking required fields as required
  • DONE: Requiring a name and e-mail address (nevermind i'm doing this now— i thought if we configured at /admin/structure/types/manage/blog/fields/node.blog.comment to have "Anonymous posters must leave their contact information" it makes a homepage URL required also, which is a bit aggressive even for us proponents of the IndieWeb, but it's just name and e-mail that get required)
  • Condensing the form by making labels inline
  • Take over FlatComments and release @gnuget's port to Drupal 8 as an official FlatComments module release, and start using it to ensure we have no weird threading issues (and to hide the reply link while allowing the edit link).
  • Allowing people to register at all
  • Make it so people can register while leaving a comment
  • Theming 'standalone' comment form pages like this or making them effectively impossible to reach (fixing JavaScript form validation to warn and prevent submission when the comment textarea field is effectively empty).
@cedewey i will close this, but the potential followups are: * Providing a nicer message about awaiting comment approval by overriding the text from `web/core/modules/comment/src/CommentForm.php` line 388, 'Your comment has been queued for review by site administrators and will be published after approval.', by putting a string override in `provisioning/drutopia/roles/drupal/templates/settings.local.php.j2` - #138 * Marking required fields as required * DONE: Requiring a name and e-mail address (nevermind i'm doing this now— i thought if we configured at `/admin/structure/types/manage/blog/fields/node.blog.comment` to have "Anonymous posters must leave their contact information" it makes a homepage URL required also, which is a bit aggressive even for us proponents of the IndieWeb, but it's just name and e-mail that get required) * Condensing the form by making labels inline * Take over FlatComments and release @gnuget's [port to Drupal 8 as an official FlatComments module release](https://www.drupal.org/project/flatcomments/issues/2820578), and start using it to ensure we have no weird threading issues (and to hide the reply link while allowing the edit link). * Allowing people to register at all * Make it so people can [register while leaving a comment](http://data.agaric.com/better-registration-and-login-workflow-drupal-8-allowing-logging-or-registering-while-posting-conten) * Theming ['standalone' comment form pages like this](https://agaric-live-test.drutopia.org/comment/reply/node/90/comment) or making them effectively impossible to reach (fixing JavaScript form validation to warn and prevent submission when the comment textarea field is effectively empty).
mlncn commented 2018-12-27 06:41:16 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 4e209cb29b

mentioned in commit 4e209cb29bb6dff7392b1cd6ef49819d0648fe30
mlncn commented 2018-12-27 07:06:12 +00:00 (Migrated from gitlab.com)
Copy link

closed

closed
FreeScholar commented 2019-01-02 05:14:23 +00:00 (Migrated from gitlab.com)
Copy link

I see no option to leave a comment on blog post when not logged in and when logged in.
On the blog post EDIT page comments are open but it sez: Users with the "Post comments" permission can post comments.
https://agaric.coop/blog/daily-business-operations-using-free-software

I see no option to leave a comment on blog post when not logged in and when logged in. On the blog post EDIT page comments are open but it sez: Users with the "Post comments" permission can post comments. https://agaric.coop/blog/daily-business-operations-using-free-software
FreeScholar commented 2019-01-02 05:14:24 +00:00 (Migrated from gitlab.com)
Copy link

reopened

reopened
mlncn commented 2019-01-15 05:32:34 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in issue agaric/internal#178

mentioned in issue agaric/internal#178
cedewey commented 2019-01-15 22:22:54 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
cedewey commented 2019-01-15 22:23:15 +00:00 (Migrated from gitlab.com)
Copy link

changed milestone to %8

changed milestone to %8
cedewey commented 2019-08-06 22:36:53 +00:00 (Migrated from gitlab.com)
Copy link

closed

closed
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
bbb-test
D9-upgrade
drush-9-aliases
provision-dewey
No results found.
Labels
Clear labels   
A11y

Accessibility-related issues

  
Automated Testing

   
Contributable

Issues with work that can (potentially) be contributed back to Drupal or other FLOSS projects.

  
Contributed

Tag issues where we have contributed work back to FLOSS projects (replace Contributable tag; the Contributed tag can be removed once the contribution is recorded in a blog or something.

  
Decision

An issue that requires a decision be made.

  
Design

Issues that should include a UX/design work or review.

  
Development

   
Drutopia

Issues related to Drutopia features or infrastructure, or are potential Drutopia enhancements (with tag Contributable).

  
Feature Request

   
IndieWeb

Anything related to interlinking web sites in a broadly IndieWeb fashion, see https://indieweb.org/

  
Infrastructure

   
Marketing

   
Needs documentation

When an issue has uncovered something that should be documented in a user guide or the project wiki or anywhere else outside the issue queue.

  
status::Abandoned

An issue that has been abandoned and will not be completed.

  
status::Blocked

An issue that is blocked for a reason outside Agaric's control.

  
status::Deploy

An issue that has been tested and is ready to be deployed.

  
status::Doing

   
status::Done

   
status::In Review

An issue that has been completed and is ready for a code and/or design review.

  
status::Needs Clarification

   
status::Test

An issue that has been completed and is ready to be tested.

  
status::To Do

An issue that is an agreed priority and has all information needed to be completed.

  
type::Bug

   
type::Task

   
type::User Story
No labels
A11y
Automated Testing
Contributable
Contributed
Decision
Design
Development
Drutopia
Feature Request
IndieWeb
Infrastructure
Marketing
Needs documentation
status::Abandoned
status::Blocked
status::Deploy
status::Doing
status::Done
status::In Review
status::Needs Clarification
status::Test
status::To Do
type::Bug
type::Task
type::User Story
Milestone
Clear milestone
No items
No milestone
Post-Launch
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: agaric/agaric-coop#32
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?