agaric/agaric-coop
10
1
Fork 0
Code Issues 102 Pull requests Projects Releases Packages Wiki Activity

A site visitor can use the main menu to navigate the site. #86

New issue
Closed
opened 2018-09-27 01:06:26 +00:00 by cedewey · 15 comments
cedewey commented 2018-09-27 01:06:26 +00:00 (Migrated from gitlab.com)
Copy link

Acceptance Criteria

Work Required

  • Add appropriate markup to menu
  • Get menu background to be white and links blue (.light-header) when use has scrolled down the page
  • Get search icon to show up in menu
## Acceptance Criteria * Main Menu as it behaves in the [styleguide](http://0.0.0.0:9000/static-layouts/design-output/index.html) ## Work Required * [x] Add appropriate markup to menu * [x] Get menu background to be white and links blue (.light-header) when use has scrolled down the page * [x] Get search icon to show up in menu
cedewey commented 2018-09-27 01:07:39 +00:00 (Migrated from gitlab.com)
Copy link

@mlncn If we could take a look at this together I'm stuck as to how to get the "light-header" class applied when a user scrolls down the page.

@mlncn If we could take a look at this together I'm stuck as to how to get the "light-header" class applied when a user scrolls down the page.
cedewey commented 2018-09-27 01:09:01 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
mlncn commented 2018-09-27 01:48:53 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey if i say 'JavaScript' does that help? ;-)

@cedewey if i say 'JavaScript' does that help? ;-)
cedewey commented 2018-11-28 19:30:33 +00:00 (Migrated from gitlab.com)
Copy link

changed milestone to %7

changed milestone to %7
cedewey commented 2018-11-30 19:03:30 +00:00 (Migrated from gitlab.com)
Copy link

unassigned @cedewey

unassigned @cedewey
cedewey commented 2018-12-03 16:27:46 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item Get menu background to be white and links blue (.light-header) when use has scrolled down the page as completed

marked the checklist item **Get menu background to be white and links blue (.light-header) when use has scrolled down the page** as completed
mlncn commented 2018-12-10 23:33:33 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey uh, does anyone happen to know where any kind of search went in Drutopia?

https://agaric-live-test.drutopia.org/search just goes to a listing page without any search box.

But so does https://drutopia.org/search

I guess https://familyandhome.org/search is our model...

@cedewey uh, does anyone happen to know where *any* kind of search went in Drutopia? https://agaric-live-test.drutopia.org/search just goes to a listing page without any search box. But so does https://drutopia.org/search I guess https://familyandhome.org/search is our model...
cedewey commented 2018-12-11 01:29:59 +00:00 (Migrated from gitlab.com)
Copy link

Yeah, that search bar has been an issue that seems to come up, then get resolved then come up again...

I found the related issue - https://gitlab.com/drutopia/drutopia_search/issues/9

Yeah, that search bar has been an issue that seems to come up, then get resolved then come up again... I found the related issue - https://gitlab.com/drutopia/drutopia_search/issues/9
cedewey commented 2018-12-13 16:18:22 +00:00 (Migrated from gitlab.com)
Copy link

@mlncn search icon is now showing! however the search box is visible before hovering over the search icon.

agaric-search-box

@mlncn search icon is now showing! however the search box is visible before hovering over the search icon. ![agaric-search-box](/uploads/5f96a72f77152b406b823224f0c962ca/agaric-search-box.png)
mlncn commented 2018-12-13 16:30:30 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey if i'm in IRC you can just check if i know about an issue. That was already fixed in cd7b562894

@cedewey if i'm in IRC you can just check if i know about an issue. That was already fixed in https://gitlab.com/agaric/patternlibrary/commit/cd7b562894cb0430883f99d998171498b75f6e84
mlncn commented 2018-12-24 23:08:39 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item Get search icon to show up in menu as completed

marked the checklist item **Get search icon to show up in menu** as completed
mlncn commented 2018-12-24 23:09:29 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @cedewey and unassigned @mlncn

assigned to @cedewey and unassigned @mlncn
cedewey commented 2018-12-27 00:01:49 +00:00 (Migrated from gitlab.com)
Copy link

closed

closed
mlncn commented 2020-03-02 09:29:34 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit agaric/patternlibrary@5a8e3c221a

mentioned in commit agaric/patternlibrary@5a8e3c221a66bd40218d92578fd554f955020fd1
mlncn commented 2020-03-02 14:32:35 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit f42a6fbdd1

mentioned in commit f42a6fbdd10952ec9569aebf5e11bc1a5984b10e
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
bbb-test
D9-upgrade
drush-9-aliases
provision-dewey
No results found.
Labels
Clear labels   
A11y

Accessibility-related issues

  
Automated Testing

   
Contributable

Issues with work that can (potentially) be contributed back to Drupal or other FLOSS projects.

  
Contributed

Tag issues where we have contributed work back to FLOSS projects (replace Contributable tag; the Contributed tag can be removed once the contribution is recorded in a blog or something.

  
Decision

An issue that requires a decision be made.

  
Design

Issues that should include a UX/design work or review.

  
Development

   
Drutopia

Issues related to Drutopia features or infrastructure, or are potential Drutopia enhancements (with tag Contributable).

  
Feature Request

   
IndieWeb

Anything related to interlinking web sites in a broadly IndieWeb fashion, see https://indieweb.org/

  
Infrastructure

   
Marketing

   
Needs documentation

When an issue has uncovered something that should be documented in a user guide or the project wiki or anywhere else outside the issue queue.

  
status::Abandoned

An issue that has been abandoned and will not be completed.

  
status::Blocked

An issue that is blocked for a reason outside Agaric's control.

  
status::Deploy

An issue that has been tested and is ready to be deployed.

  
status::Doing

   
status::Done

   
status::In Review

An issue that has been completed and is ready for a code and/or design review.

  
status::Needs Clarification

   
status::Test

An issue that has been completed and is ready to be tested.

  
status::To Do

An issue that is an agreed priority and has all information needed to be completed.

  
type::Bug

   
type::Task

   
type::User Story
No labels
A11y
Automated Testing
Contributable
Contributed
Decision
Design
Development
Drutopia
Feature Request
IndieWeb
Infrastructure
Marketing
Needs documentation
status::Abandoned
status::Blocked
status::Deploy
status::Doing
status::Done
status::In Review
status::Needs Clarification
status::Test
status::To Do
type::Bug
type::Task
type::User Story
Milestone
Clear milestone
No items
No milestone
Site Launch
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: agaric/agaric-coop#86
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?