diff --git a/README.md b/README.md index 7d5d695..e9bad0f 100644 --- a/README.md +++ b/README.md @@ -11,10 +11,12 @@ To do a build/push to our container registry, first create a token at https://gi Then, run: ``` -docker build -t git.agaric.com/agaric/deploycontainer:latest . +# finish commits and testing +git tag "0.0.X" +docker build -t git.agaric.com/agaric/deploycontainer:0.0.X +docker tag git.agaric.com/agaric/deploycontainer:0.0.X git.agaric.com/agaric/deploycontainer:latest docker push git.agaric.com/agaric/deploycontainer:latest ``` - -No, this is not best practice - the latest should only point to latest, and there should be a semver in use. +Need to verify pushing latest also includes the version...not sure If you need a token for git access to git.drupalcode.org, go to https://git.drupalcode.org/-/user_settings/personal_access_tokens and grant the token api_read access. The token can be tested (i.e. inside a deploycontainer - `docker run -v .:/home/deployer -it agaric/deploycontainer:latest`) with `composer config -g gitlab-token.git.drupalcode.org {your token}` and then running composer install.