From ef5f877a60c47d2f85608e7f92eae3216c68a7c2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?benjamin=20melan=C3=A7on?= <ben@agaric.com>
Date: Tue, 1 Jan 2019 11:09:08 -0500
Subject: [PATCH] Successfully add link classes to active item ancestor,
 without hangover

Unlike 9e47f0c7cb5a where i was just trying to avoid creating the link_attributes
object for every item.  That was not to be.
---
 agaric/templates/navigation/menu.html.twig | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/agaric/templates/navigation/menu.html.twig b/agaric/templates/navigation/menu.html.twig
index 1cd37b5..f2f4e89 100644
--- a/agaric/templates/navigation/menu.html.twig
+++ b/agaric/templates/navigation/menu.html.twig
@@ -33,7 +33,6 @@
 {{ menus.menu_links(items, attributes, 0, menu_name) }}
 {% macro menu_links(items, attributes, menu_level, menu_name) %}
   {% set submenu_attributes = create_attribute() %}
-  {% set link_attributes = create_attribute() %}
   {% import _self as menus %}
   {% set submenu_classes = [
     'navbar-item',
@@ -45,11 +44,11 @@
       <div{{ submenu_attributes.addClass(submenu_classes) }}>
     {% endif %}
     {% for item in items %}
-      {% set link_classes = ['navbar-item'] %}
+      {% set link_attributes = create_attribute().addClass('navbar-item') %}
       {% if item.in_active_trail %}
-        {% set link_classes = link_classes|merge(['is-active']) %}
+        {% set link_attributes = link_attributes.addClass('is-active') %}
       {% endif %}
-      {{ link(item.title, item.url, link_attributes.addClass(link_classes)) }}
+      {{ link(item.title, item.url, link_attributes) }}
       {% if item.below %}
         {{ menus.menu_links(item.below, attributes, menu_level + 1) }}
       {% endif %}