Embedded iframes for audio such as podcasts should not receive the same minimum height intended for videos

mlncn commented

2020-06-24 12:54:37 +00:00

(Migrated from gitlab.com)

This leads to a large gap below the audio player, which makes it look like there is no text content (when in fact there is, it's just pushed far down).

The min-height in this rule is the problem:

iframe {
    width: 100%;
    height: 100%;
    min-height: 36vw;
}

Either need to find a way to distinguish audio from video embeds, or find another way to keep video fully visible.

This leads to a large gap below the audio player, which makes it look like there is no text content (when in fact there is, it's just pushed far down). The `min-height` in this rule is the problem: ```css iframe { width: 100%; height: 100%; min-height: 36vw; } ``` Either need to find a way to distinguish audio from video embeds, or find another way to keep video fully visible.

FreeScholar commented

2021-03-30 17:43:01 +00:00

(Migrated from gitlab.com)

assigned to @mlncn

joshua_davis commented

2021-08-02 18:44:58 +00:00

(Migrated from gitlab.com)

Any updates on this?

FreeScholar commented

2021-08-12 01:08:21 +00:00

(Migrated from gitlab.com)

Will tug on Ben's cape and update ASAP.

mlncn commented

2021-08-17 11:15:51 +00:00

(Migrated from gitlab.com)

mentioned in commit e14de651bd

mentioned in commit e14de651bdd606586818552116da32a0e11e7575

mlncn commented

2021-08-17 12:23:35 +00:00

(Migrated from gitlab.com)

mentioned in commit c85ffc32b4

mentioned in commit c85ffc32b490d510acc119c2ae0c074e1218f589

sanjayjaindc commented

2021-08-18 20:18:16 +00:00

(Migrated from gitlab.com)

We have deployed this module in the test site https://www.drupal.org/project/fitvids

It seems to be working correctly in https://geo-test.drutopia.org/articles/changing-stigma-resident-owned-communities

Please verify in other known pages where the issue was a problem. If the issue is resolved we can deploy in the live site.

We have deployed this module in the test site https://www.drupal.org/project/fitvids It seems to be working correctly in https://geo-test.drutopia.org/articles/changing-stigma-resident-owned-communities Please verify in other known pages where the issue was a problem. If the issue is resolved we can deploy in the live site.

sanjayjaindc commented

2021-08-18 20:18:29 +00:00

(Migrated from gitlab.com)

assigned to @joshua_davis and unassigned @mlncn

joshua_davis commented

2021-08-18 20:34:53 +00:00

(Migrated from gitlab.com)

Looks good on the test site. Ready to deploy!

mlncn commented

2021-08-19 02:48:52 +00:00

(Migrated from gitlab.com)

@joshua_davis @sanjayjaindc deployed live now.

Rows
Columns

Embedded iframes for audio such as podcasts should not receive the same minimum height intended for videos #111