Inline image captions are not displaying

mlncn commented

2019-10-01 04:23:03 +00:00

(Migrated from gitlab.com)

cc @FreeScholar @cedewey @joshua_davis

At least some content has image captions, that look like this:

The text itself is present:

<img alt="" class="image-inline caption" src="/sites/default/files/styles/inline/public/cheryl-angel.jpeg?itok=s19Mwroq" style="width: 400px; height: 240px; float: right;" title="Cheryl Angel in a late-night talking circle, sharing reflections about her Lakota ancestors: “We were never into entitlement; that's why we didn't have kings. We were into revering, honoring, relating to everything around us. All of these living spirits around us… That's the system nobody is talking about, that needs to be protected.”" />

But it just doesn't display on the new site:

https://geo.coop/story/how-women-standing-rock-are-building-sovereign-economies

Test that the text does not get entirely lost when content is saved (because the WYSIWYG doesn't display it either)
Based largely on the above test, decide how urgent
Determine best way to fix, in light of above— two main approaches being getting the existing code to display, or reformatting it to fit the current sites approach to captions
Fix.

cc @FreeScholar @cedewey @joshua_davis At least some content has image captions, that look like this: ![Screenshot_2019-10-01_How_the_Women_of_Standing_Rock_Are_Building_Sovereign_Economies_Grassroots_Economic_Organizing](/uploads/ba6b0bc93567ede9c3512d2dee095a93/Screenshot_2019-10-01_How_the_Women_of_Standing_Rock_Are_Building_Sovereign_Economies_Grassroots_Economic_Organizing.png) The text itself is present: ```html <img alt="" class="image-inline caption" src="/sites/default/files/styles/inline/public/cheryl-angel.jpeg?itok=s19Mwroq" style="width: 400px; height: 240px; float: right;" title="Cheryl Angel in a late-night talking circle, sharing reflections about her Lakota ancestors: “We were never into entitlement; that's why we didn't have kings. We were into revering, honoring, relating to everything around us. All of these living spirits around us… That's the system nobody is talking about, that needs to be protected.”" /> ``` But it just doesn't display on the new site: https://geo.coop/story/how-women-standing-rock-are-building-sovereign-economies * [ ] Test that the text does not get entirely lost when content is saved (because the WYSIWYG doesn't display it either) * [ ] Based largely on the above test, decide how urgent * [ ] Determine best way to fix, in light of above— two main approaches being getting the existing code to display, or reformatting it to fit the current sites approach to captions * [ ] Fix.

mlncn commented

2019-10-01 04:23:03 +00:00

(Migrated from gitlab.com)

changed milestone to %1

mlncn commented

2019-10-01 04:27:12 +00:00

(Migrated from gitlab.com)

OK i just realized that the text shows up as a title tool tip when you hover over the image, which works for desktop if not mobile.

@joshua_davis maybe that's good enough?

OK i just realized that the text shows up as a title tool tip when you hover over the image, which works for desktop if not mobile. @joshua_davis maybe that's good enough?

mlncn commented

2019-10-01 04:27:12 +00:00

(Migrated from gitlab.com)

assigned to @joshua_davis

joshua_davis commented

2019-10-01 16:12:39 +00:00

(Migrated from gitlab.com)

It's probably ok. I'm assuming that this will only be an issue on
migrated articles, but not on articles created in Drutopia, correct?
Assuming that's the case, I think we can just leave it as is for now and
try to get the captions to display on the old articles later, as you
have time to fiddle with it.

It's probably ok. I'm assuming that this will only be an issue on migrated articles, but not on articles created in Drutopia, correct? Assuming that's the case, I think we can just leave it as is for now and try to get the captions to display on the old articles later, as you have time to fiddle with it.

joshua_davis commented

2019-10-01 18:08:36 +00:00

(Migrated from gitlab.com)

After uploading the first article, I see that I was wrong, and we do need to fix this. Images in articles, blogs, and gleanings all need to have a caption that displays without having to hover over the image, so I guess the alt text box is not sufficient, unless the text there can be made to show up without user interaction. This is a fairly high priority for us. If it's too hard to fix for the articles from the old site, I can deal with that, but this functionality really needs to be available for posts made going forward.

After uploading the first article, I see that I was wrong, and we do need to fix this. Images in articles, blogs, and gleanings all need to have a caption that displays without having to hover over the image, so I guess the alt text box is not sufficient, unless the text there can be made to show up without user interaction. This is a fairly high priority for us. If it's too hard to fix for the articles from the old site, I can deal with that, but this functionality **really** needs to be available for posts made going forward.

cedewey commented

2019-10-01 18:24:59 +00:00

(Migrated from gitlab.com)

The site does support captions for inline images, though not as intuitive as I'd like.

Here's how:

Click the image in the WYSIWYG editor
Check the caption box when you upload your image
Scroll to the bottom of the image you just added, you'll see "Enter caption here." text, click into that and type in your caption.

I've created an unpublished article as an example - https://geo.coop/articles/test-article-inline-image-and-caption

The site does support captions for inline images, though not as intuitive as I'd like. Here's how: 1. Click the image in the WYSIWYG editor 2. Check the caption box when you upload your image ![geo-caption](/uploads/8c14f7a922a7aa9499466f983506a01a/geo-caption.png) 3. Scroll to the bottom of the image you just added, you'll see "Enter caption here." text, click into that and type in your caption. I've created an unpublished article as an example - https://geo.coop/articles/test-article-inline-image-and-caption ![geo-caption-2](/uploads/4b7877ce35772622678511523229aac6/geo-caption-2.png)

joshua_davis commented

2019-10-01 18:42:42 +00:00

(Migrated from gitlab.com)

OK. I see how to do that, although it totally defeats the purpose of
having the "Add Image" button under the default text box.

OK. I see how to do that, although it totally defeats the purpose of having the "Add Image" button under the default text box.

cedewey commented

2019-10-01 19:05:04 +00:00

(Migrated from gitlab.com)

Yeah, for sure. What's your preference with working with images (assuming you could do captions either way): only use the Image paragraph, only add images inline within a text field, or both?

joshua_davis commented

2019-10-01 19:10:43 +00:00

(Migrated from gitlab.com)

I would prefer to be able to use the Image paragraph, rather than adding
the images inline, which is pretty clunky.

I would prefer to be able to use the Image paragraph, rather than adding the images inline, which is pretty clunky.

mlncn commented

2019-10-01 22:10:34 +00:00

(Migrated from gitlab.com)

We can add a caption to the image paragraph for sure. @drutopia feature!

Let's keep this issue about the past images and captions though. @cedewey did you test if historical caption data is lost on edit? That's the urgency-determiner.

We can add a caption to the image paragraph for sure. @drutopia feature! Let's keep this issue about the past images and captions though. @cedewey did you test if historical caption data is lost on edit? That's the urgency-determiner.

mlncn commented

2019-10-01 22:12:33 +00:00

(Migrated from gitlab.com)

Created #69 for new images/captions.

Rows
Columns

Inline image captions are not displaying #62