Style three panel of blocks on homepage #108

Closed
opened 2018-11-20 23:11:30 +00:00 by cedewey · 8 comments
cedewey commented 2018-11-20 23:11:30 +00:00 (Migrated from gitlab.com)
URL: https://agaric-live-test.drutopia.org/ ![homepage-blocks](/uploads/91e387f32f19a5e77d8a783e5cf370f5/homepage-blocks.png)
mlncn commented 2018-11-21 07:03:55 +00:00 (Migrated from gitlab.com)

mentioned in issue #106

mentioned in issue #106
mlncn commented 2018-11-21 16:47:51 +00:00 (Migrated from gitlab.com)

@cedewey As usual, everything entails 14 more decisions even after the 73 unexpected problems are dealt with. The content bottom column 'slide' blocks (not talking about the carousel paragraph right now) are designed to require a link that wraps the entire thing

This means links inside the text are a bad idea. I can make the link surrounding the whole block optional pretty easily i think, but we still have to sort of know not to have both the wrapper link and an internal link. And as you've experienced, giving loaded guns to content editors maybe isn't the best thing.

So the question is do you want to drop the wrapper link, make it required and make links in text impossible (with a new input format), try to do a trick to allow both (which i did for GUTS teasers somehow), or document in the field help texts that content editors should choose between having a wrapper link or having links in content?

.... or we could find a way to make the input format conditional on something being in another field :-P

@cedewey As usual, everything entails 14 more decisions even after the 73 unexpected [problems](https://gitlab.com/agaric/patternlibrary/blob/master/agaric/templates/paragraph/paragraph--slide.html.twig) are dealt with. The content bottom column 'slide' blocks (not talking about the carousel paragraph right now) are designed to require a link that wraps the entire thing This means links inside the text are a bad idea. I can make the link surrounding the whole block optional pretty easily i think, but we still have to sort of know not to have both the wrapper link and an internal link. And as you've experienced, giving loaded guns to content editors maybe isn't the best thing. So the question is do you want to drop the wrapper link, make it required and make links in text impossible (with a new input format), try to do a trick to allow both (which i did for GUTS teasers somehow), or document in the field help texts that content editors should choose between having a wrapper link or having links in content? .... or we could find a way to make the input format conditional on something being in another field :-P
cedewey commented 2018-11-22 17:46:34 +00:00 (Migrated from gitlab.com)

as noted in IRC, let's make the entire block link optional. Editors will need to remember they cannot link the entire block AND have links within the text.

as noted in IRC, let's make the entire block link optional. Editors will need to remember they cannot link the entire block AND have links within the text.
mlncn commented 2018-11-22 18:07:10 +00:00 (Migrated from gitlab.com)

assigned to @cedewey and unassigned @mlncn

assigned to @cedewey and unassigned @mlncn
mlncn commented 2018-11-22 18:07:13 +00:00 (Migrated from gitlab.com)

@cedewey Look at the ugliness you made me do! 9ae8cfe14c

But done.

@cedewey Look at the ugliness you made me do! https://gitlab.com/agaric/patternlibrary/commit/9ae8cfe14cbd35b654c6cf48cc50f1da0c6b85aa But done.
cedewey commented 2018-11-28 19:32:43 +00:00 (Migrated from gitlab.com)

changed milestone to %7

changed milestone to %7
cedewey commented 2018-11-28 19:42:42 +00:00 (Migrated from gitlab.com)

Looks good!

Looks good!
cedewey commented 2018-11-28 19:42:42 +00:00 (Migrated from gitlab.com)

closed

closed
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: agaric/agaric-coop#108
No description provided.