agaric/agaric-coop
10
1
Fork 0
Code Issues 102 Pull requests Projects Releases Packages Wiki Activity

A visitor can read a blog post #33

New issue
Closed
opened 2017-12-15 21:54:38 +00:00 by cedewey · 31 comments
cedewey commented 2017-12-15 21:54:38 +00:00 (Migrated from gitlab.com)
Copy link

Acceptance Criteria

Given that I am a vistor,
when I visit a blog post
then I see the post details and comments.

Notes

QA

https://agaric-live-test.drutopia.org/blog/global-training-day-fun-and-accesible-all

Work Remaining

  • @mlncn Display header with blue background
  • @cedewey Add spacing between tags
  • @cedewey Add title paragraph to Blog Post
  • @mlncn Style comments
## Acceptance Criteria Given that I am a vistor, when I visit a blog post then I see the post details and comments. ## Notes * [Blog Post Wireframe](https://marvelapp.com/5c327g8/screen/36342186) ## QA https://agaric-live-test.drutopia.org/blog/global-training-day-fun-and-accesible-all ## Work Remaining * [x] @mlncn Display header with blue background * [x] @cedewey Add spacing between tags * [x] @cedewey Add title paragraph to Blog Post * [x] @mlncn Style comments
cedewey commented 2018-01-24 20:54:22 +00:00 (Migrated from gitlab.com)
Copy link

added ~3378865 label

added ~3378865 label
cedewey commented 2018-01-24 21:07:50 +00:00 (Migrated from gitlab.com)
Copy link

changed milestone to %4

changed milestone to %4
cedewey commented 2018-01-24 21:18:29 +00:00 (Migrated from gitlab.com)
Copy link

added ~3378960 label

added ~3378960 label
cedewey commented 2018-09-26 16:19:30 +00:00 (Migrated from gitlab.com)
Copy link

changed milestone to %3

changed milestone to %3
cedewey commented 2018-09-26 16:19:30 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @mlncn

assigned to @mlncn
cedewey commented 2018-11-28 19:30:31 +00:00 (Migrated from gitlab.com)
Copy link

changed milestone to %7

changed milestone to %7
cedewey commented 2018-11-28 23:38:33 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
cedewey commented 2018-11-30 19:21:54 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
cedewey commented 2018-12-07 18:30:32 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
cedewey commented 2018-12-07 18:31:23 +00:00 (Migrated from gitlab.com)
Copy link

changed the description

changed the description
mlncn commented 2018-12-09 04:30:39 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey throwing random info in this issue because it's the top one assigned to me and i can't find a better place in all 56 already open issues (same as the number of points that the Celtics set a team record in winning by tonight, if Micky doesn't yell at me for paying attention to pro sports we know she never read this issue).

  • The "Just one more thing" blocks on the home page will need to have their content edited to use title / subtitle classes when the whole-block link is used. (Well, 'need' barring some work beyond what the styleguide currently supports).
  • For the case study listings to work, the title paragraph has to be first. I definitely could fix this but we show the title paragraph first anyway, so might as well print it.
  • Something else i forgot...
@cedewey throwing random info in this issue because it's the top one assigned to me and i can't find a better place in all 56 already open issues (same as the number of points that the Celtics set a team record in winning by tonight, if Micky doesn't yell at me for paying attention to pro sports we know she never read this issue). * The "Just one more thing" blocks on the home page will need to have their content edited to use title / subtitle classes when the whole-block link is used. (Well, 'need' barring some work beyond what the styleguide currently supports). * For the case study listings to work, the title paragraph has to be first. I definitely could fix this but we show the title paragraph first anyway, so might as well print it. * Something else i forgot...
mlncn commented 2018-12-09 04:32:57 +00:00 (Migrated from gitlab.com)
Copy link

Oh yeah if you configured core.entity_form_display.node.action.default for something special, i just blew it away deploying, sorry.

Oh yeah if you configured core.entity_form_display.node.action.default for something special, i just blew it away deploying, sorry.
mlncn commented 2018-12-09 18:41:16 +00:00 (Migrated from gitlab.com)
Copy link

Also, does changing milestones help you? Because aside from the noise of notifications, it gives all issues the same last updated date, which makes the queue less useful to me at least.

Also, does changing milestones help you? Because aside from the noise of notifications, it gives all issues the same last updated date, which makes the queue less useful to me at least.
mlncn commented 2018-12-09 18:42:18 +00:00 (Migrated from gitlab.com)
Copy link

closed via commit 2aa96fc30c

closed via commit 2aa96fc30c5c87b7e4b39b1e142f23cd90bcad48
mlncn commented 2018-12-09 18:42:55 +00:00 (Migrated from gitlab.com)
Copy link

I said partially fixes, sheesh GitLab.

I said *partially* fixes, sheesh GitLab.
mlncn commented 2018-12-09 18:42:55 +00:00 (Migrated from gitlab.com)
Copy link

reopened

reopened
mlncn commented 2018-12-09 18:43:57 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item @mlncn Display header with blue background as completed

marked the checklist item **@mlncn Display header with blue background** as completed
cedewey commented 2018-12-09 19:34:43 +00:00 (Migrated from gitlab.com)
Copy link
  • I don't understand why we need to add the title class to the "One more thing" block. It looks as I'd expected right now. Adding the title class would just change the text to be large (title sized).
  • The case studies I checked have the title paragraph first. I looked at/work-0 and the content that should be printed is, we just need those squares to be layed out properly.
  • The form display changes must have been incidental, I had no intention of changing that so yeah all is good.
  • Having accurate milestones is helpful, but since this one is called site launch we'll keep the milestone the same for issues until launch.

Also, my local dev environment is borked, so I'm limited to what I can help with on the live site for now. I've opened an issue at #116

* I don't understand why we need to add the title class to the "One more thing" block. It looks as I'd expected right now. Adding the title class would just change the text to be large (title sized). * The case studies I checked have the title paragraph first. I looked at/work-0 and the content that should be printed is, we just need those squares to be layed out properly. * The form display changes must have been incidental, I had no intention of changing that so yeah all is good. * Having accurate milestones is helpful, but since this one is called site launch we'll keep the milestone the same for issues until launch. Also, my local dev environment is borked, so I'm limited to what I can help with on the live site for now. I've opened an issue at #116
mlncn commented 2018-12-10 03:18:56 +00:00 (Migrated from gitlab.com)
Copy link
  • So the thing with the "One more thing" blocks is if you hover over the one that has a surrounding a tag it becomes hard to read:
    Screenshot_2018-12-09_Home_page_Agaric
    And following Todd's styles what i'm calling in the WYSIWYG styles dropdown "Small title" and "Small subtitle" with is-5 and is-6 classes included, respectively, actually makes the text smaller than regular text. And, crucially, it keeps it black instead of turning white. This could be fixed by changing the stylesheet also but getting links to turn the right color are causing enough trouble that if with a little manual work we can stay within the existing styles, i'd prefer that.
  • Ah sorry i should have provided a link to the case study, seeing as i spent 10 minutes getting the view to output the node ID along with the comment <!-- This content not shown because it does not have a title paragraph. --> - namely https://agaric-live-test.drutopia.org/node/153/edit
  • Ah good. I can close the browser tab that still shows the changes then. :-)
  • Thanks!
* So the thing with the "One more thing" blocks is if you hover over the one that has a surrounding `a` tag it becomes hard to read: ![Screenshot_2018-12-09_Home_page_Agaric](/uploads/88319eff790c49ff903636dff8e00117/Screenshot_2018-12-09_Home_page_Agaric.png) And following Todd's styles what i'm calling in the WYSIWYG styles dropdown "Small title" and "Small subtitle" with `is-5` and `is-6` classes included, respectively, actually makes the text *smaller* than regular text. And, crucially, it keeps it black instead of turning white. This could be fixed by changing the stylesheet also but getting links to turn the right color are causing enough trouble that if with a little manual work we can stay within the existing styles, i'd prefer that. * Ah sorry i should have provided a link to the case study, seeing as i spent 10 minutes getting the view to output the node ID along with the comment `<!-- This content not shown because it does not have a title paragraph. -->` - namely https://agaric-live-test.drutopia.org/node/153/edit * Ah good. I can close the browser tab that still shows the changes then. :-) * Thanks!
mlncn commented 2018-12-10 04:17:59 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit c10dd9046e

mentioned in commit c10dd9046e9acaabbb2602b48c63cebe66229ab3
cedewey commented 2018-12-10 14:40:23 +00:00 (Migrated from gitlab.com)
Copy link
  • Got it. Ok style has been applied. It's more readable. I don't like that the font size and weight doesn't match the other blocks, so some other long-term solution would be good to get in place. We can use it as a temporary workaround for now though.
  • case study updated!

While I'm in travel limbo (flight just got delayed again...) and my local is borked feel free to claim any of the tasks on this issue currently assigned to me.

* Got it. Ok style has been applied. It's more readable. I don't like that the font size and weight doesn't match the other blocks, so some other long-term solution would be good to get in place. We can use it as a temporary workaround for now though. * case study updated! While I'm in travel limbo (flight just got delayed again...) and my local is borked feel free to claim any of the tasks on this issue currently assigned to me.
mlncn commented 2018-12-10 15:29:49 +00:00 (Migrated from gitlab.com)
Copy link

Oh, well, there's nothing stopping us from applying those styles to the other blocks also. The gold-plated solution would be to have title and body fields and apply all the styles automatically, but i'm trying to step away from gold-plated solutions :-)

Oh, well, there's nothing stopping us from applying those styles to the other blocks also. The gold-plated solution would be to have title and body fields and apply all the styles automatically, but i'm trying to step away from gold-plated solutions :-)
cedewey commented 2018-12-10 17:20:16 +00:00 (Migrated from gitlab.com)
Copy link

True true. I've updated the blocks with the small title. It's my favorite of the three for those blocks, though their original style is still the best... ;P

True true. I've updated the blocks with the small title. It's my favorite of the three for those blocks, though their original style is still the best... ;P
mlncn commented 2018-12-10 17:39:12 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in issue #117

mentioned in issue #117
mlncn commented 2018-12-10 18:12:56 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item @mlncn Style comments as completed

marked the checklist item **@mlncn Style comments** as completed
mlncn commented 2018-12-10 19:20:02 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item @cedewey Add spacing between tags as completed

marked the checklist item **@cedewey Add spacing between tags** as completed
mlncn commented 2018-12-10 19:20:03 +00:00 (Migrated from gitlab.com)
Copy link

marked the checklist item @cedewey Add title paragraph to Blog Post as completed

marked the checklist item **@cedewey Add title paragraph to Blog Post** as completed
mlncn commented 2018-12-10 19:20:10 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @cedewey and unassigned @mlncn

assigned to @cedewey and unassigned @mlncn
mlncn commented 2018-12-10 19:20:37 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey deployed— good to go live with, you think?

@cedewey deployed— good to go live with, you think?
cedewey commented 2018-12-10 19:39:23 +00:00 (Migrated from gitlab.com)
Copy link

This looks great!

This looks great!
cedewey commented 2018-12-10 19:39:23 +00:00 (Migrated from gitlab.com)
Copy link

closed

closed
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
bbb-test
D9-upgrade
drush-9-aliases
provision-dewey
No results found.
Labels
Clear labels   
A11y

Accessibility-related issues

  
Automated Testing

   
Contributable

Issues with work that can (potentially) be contributed back to Drupal or other FLOSS projects.

  
Contributed

Tag issues where we have contributed work back to FLOSS projects (replace Contributable tag; the Contributed tag can be removed once the contribution is recorded in a blog or something.

  
Decision

An issue that requires a decision be made.

  
Design

Issues that should include a UX/design work or review.

  
Development

   
Drutopia

Issues related to Drutopia features or infrastructure, or are potential Drutopia enhancements (with tag Contributable).

  
Feature Request

   
IndieWeb

Anything related to interlinking web sites in a broadly IndieWeb fashion, see https://indieweb.org/

  
Infrastructure

   
Marketing

   
Needs documentation

When an issue has uncovered something that should be documented in a user guide or the project wiki or anywhere else outside the issue queue.

  
status::Abandoned

An issue that has been abandoned and will not be completed.

  
status::Blocked

An issue that is blocked for a reason outside Agaric's control.

  
status::Deploy

An issue that has been tested and is ready to be deployed.

  
status::Doing

   
status::Done

   
status::In Review

An issue that has been completed and is ready for a code and/or design review.

  
status::Needs Clarification

   
status::Test

An issue that has been completed and is ready to be tested.

  
status::To Do

An issue that is an agreed priority and has all information needed to be completed.

  
type::Bug

   
type::Task

   
type::User Story
No labels
A11y
Automated Testing
Contributable
Contributed
Decision
Design
Development
Drutopia
Feature Request
IndieWeb
Infrastructure
Marketing
Needs documentation
status::Abandoned
status::Blocked
status::Deploy
status::Doing
status::Done
status::In Review
status::Needs Clarification
status::Test
status::To Do
type::Bug
type::Task
type::User Story
Milestone
Clear milestone
No items
No milestone
Site Launch
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: agaric/agaric-coop#33
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?