Resolve "Error when trying to install Drutopia Case Study" #268

Merged
cedewey merged 1 commit from 94-case-study-dependencies into master 2018-10-18 21:31:28 +00:00
cedewey commented 2018-10-18 17:03:27 +00:00 (Migrated from gitlab.com)

Closes #94

This adds the missing configuration for the Case Study content type. Also, the license vocab configuration had been mistakenly added to the Case Study feature. I moved this to its proper home in Creative License.

I don't know if I should by including the Config Snapshot provided file - config_sync.module.drutopia_case_study but it's being suggested through the Features UI so it's in there.

Closes #94 This adds the missing configuration for the Case Study content type. Also, the license vocab configuration had been mistakenly added to the Case Study feature. I moved this to its proper home in Creative License. I don't know if I should by including the Config Snapshot provided file - config_sync.module.drutopia_case_study but it's being suggested through the Features UI so it's in there.
mlncn (Migrated from gitlab.com) approved these changes 2018-10-18 17:03:27 +00:00
mlncn commented 2018-10-18 20:04:46 +00:00 (Migrated from gitlab.com)

@cedewey that would be a bug with Features. Core to look/file? The snapshot should not ever be part of the install, optional, or any other sort of configuration. Not sure what happens if snapshot tries to snapshot itself but anyway it shouldn't be there.

@cedewey that would be a bug with Features. Core to look/file? The snapshot should not ever be part of the install, optional, or any other sort of configuration. Not sure what happens if snapshot tries to snapshot itself but anyway it shouldn't be there.
mlncn commented 2018-10-18 20:05:57 +00:00 (Migrated from gitlab.com)

@cedewey Please remove this file; i don't see a straightforward way to throw it out when merging.

@cedewey Please remove this file; i don't see a straightforward way to throw it out when merging.
mlncn commented 2018-10-18 20:14:01 +00:00 (Migrated from gitlab.com)

@cedewey And are we missing any taxonomy term configuration between the two modules? Or is core.entity_view_display.taxonomy_term.license.default.yml it? No form view mode, or display view mode for the other vocabularies?

@cedewey And are we missing any taxonomy *term* configuration between the two modules? Or is `core.entity_view_display.taxonomy_term.license.default.yml` it? No form view mode, or display view mode for the other vocabularies?
cedewey commented 2018-10-18 20:51:43 +00:00 (Migrated from gitlab.com)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/sites/agaric-com/merge_requests/25/diffs?diff_id=25455529&start_sha=1ee97a93e0c9935a645520b240b2fa5859db2a7f#7c44e4b4744f83f9580f833e27757660b8d1a81f_1_0)
cedewey commented 2018-10-18 20:51:43 +00:00 (Migrated from gitlab.com)

added 1 commit

Compare with previous version

added 1 commit <ul><li>c493abe8 - Remove config snapshot file</li></ul> [Compare with previous version](https://gitlab.com/agaric/sites/agaric-com/merge_requests/25/diffs?diff_id=25455529&start_sha=1ee97a93e0c9935a645520b240b2fa5859db2a7f)
cedewey commented 2018-10-18 20:52:07 +00:00 (Migrated from gitlab.com)

ok, I removed this.

ok, I removed this.
cedewey commented 2018-10-18 20:52:08 +00:00 (Migrated from gitlab.com)

resolved all discussions

resolved all discussions
cedewey commented 2018-10-18 20:54:14 +00:00 (Migrated from gitlab.com)

@mlncn I checked and there isn't a view mode or display view mode to include for the other vocabularies.

@mlncn I checked and there isn't a view mode or display view mode to include for the other vocabularies.
mlncn commented 2018-10-18 21:30:54 +00:00 (Migrated from gitlab.com)

approved this merge request

approved this merge request
mlncn commented 2018-10-18 21:31:27 +00:00 (Migrated from gitlab.com)

mentioned in commit 2c4c2fdcd1

mentioned in commit 2c4c2fdcd14d794ef61e4b2fa8e3f828bfcf3cd3
mlncn commented 2018-10-18 21:31:28 +00:00 (Migrated from gitlab.com)

merged

merged
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: agaric/agaric-coop#268
No description provided.