agaric/agaric-coop
10
1
Fork 0
Code Issues 102 Pull requests Projects Releases Packages Wiki Activity

Enable OpenGraph module and configure sensible defaults for OpenGraph metatag #295

Merged
cedewey merged 1 commit from 177-open-graph into master 2019-02-01 18:46:25 +00:00
Conversation 17 Commits 1 Files changed 1 +5 -5
cedewey commented 2019-01-18 22:57:01 +00:00 (Migrated from gitlab.com)
Copy link

Closes #177

Closes #177
cedewey commented 2019-01-18 22:57:01 +00:00 (Migrated from gitlab.com)
Copy link

changed milestone to %8

changed milestone to %8
mlncn (Migrated from gitlab.com) approved these changes 2019-01-18 22:57:01 +00:00
mlncn commented 2019-01-20 05:47:55 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey Alt text for a wordmark should be just the word, and for a logo should be just a description ("Two stylized mushrooms.")? I'm curious.

@cedewey Alt text for a wordmark should be just the word, and for a logo should be just a description ("Two stylized mushrooms.")? I'm curious.
mlncn commented 2019-01-20 05:50:32 +00:00 (Migrated from gitlab.com)
Copy link

This image path is returning 404. The other one is working, but i think we should add these images to the pattern library or just the theme. Relying on inline images which could get deleted if removed from content doesn't seem safe.

This image path is returning 404. The other one is working, but i think we should add these images to the pattern library or just the theme. Relying on inline images which could get deleted if removed from content doesn't seem safe.
mlncn commented 2019-01-20 05:51:53 +00:00 (Migrated from gitlab.com)
Copy link

approved this merge request

approved this merge request
cedewey commented 2019-01-23 20:41:02 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in merge request agaric/patternlibrary!11

mentioned in merge request agaric/patternlibrary!11
cedewey commented 2019-01-23 20:41:19 +00:00 (Migrated from gitlab.com)
Copy link

Images added to pattern library - https://gitlab.com/agaric/patternlibrary/merge_requests/11

Images added to pattern library - https://gitlab.com/agaric/patternlibrary/merge_requests/11
mlncn commented 2019-01-24 21:54:51 +00:00 (Migrated from gitlab.com)
Copy link

OK merged that in this still needs to be updated to reference them.

OK merged that in this still needs to be updated to reference them.
mlncn commented 2019-01-27 00:48:47 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @cedewey

assigned to @cedewey
mlncn commented 2019-01-27 00:50:26 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey these are the paths that need to go to the images you added to the theme now

@cedewey these are the paths that need to go to the images you added to the theme now
cedewey commented 2019-02-01 17:51:46 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/sites/agaric-com/merge_requests/52/diffs?diff_id=33053194&start_sha=e6e1258829b829fe21861e3a92a2c1b7d70ba18d#ef91011f233d68714ec61cfebd7d391ff7292875_24_24)
cedewey commented 2019-02-01 17:51:46 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/sites/agaric-com/merge_requests/52/diffs?diff_id=33053194&start_sha=e6e1258829b829fe21861e3a92a2c1b7d70ba18d#ef91011f233d68714ec61cfebd7d391ff7292875_21_21)
cedewey commented 2019-02-01 17:51:46 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/sites/agaric-com/merge_requests/52/diffs?diff_id=33053194&start_sha=e6e1258829b829fe21861e3a92a2c1b7d70ba18d#ef91011f233d68714ec61cfebd7d391ff7292875_12_12)
cedewey commented 2019-02-01 17:51:46 +00:00 (Migrated from gitlab.com)
Copy link

added 58 commits

  • e6e12588...e6296594 - 56 commits from branch master
  • 0c5ca762 - Merge branch 'master' into 177-open-graph
  • 30a232eb - Change path of default images for metatag

Compare with previous version

added 58 commits <ul><li>e6e12588...e6296594 - 56 commits from branch <code>master</code></li><li>0c5ca762 - Merge branch &#39;master&#39; into 177-open-graph</li><li>30a232eb - Change path of default images for metatag</li></ul> [Compare with previous version](https://gitlab.com/agaric/sites/agaric-com/merge_requests/52/diffs?diff_id=33053194&start_sha=e6e1258829b829fe21861e3a92a2c1b7d70ba18d)
cedewey commented 2019-02-01 17:54:14 +00:00 (Migrated from gitlab.com)
Copy link

assigned to @mlncn

assigned to @mlncn
mlncn commented 2019-02-01 18:46:22 +00:00 (Migrated from gitlab.com)
Copy link

approved this merge request

approved this merge request
mlncn commented 2019-02-01 18:46:25 +00:00 (Migrated from gitlab.com)
Copy link

merged

merged
mlncn commented 2019-02-01 18:46:25 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit a441a260ae

mentioned in commit a441a260ae19f13eba25608f8e6f38a210ecdf62
Sign in to join this conversation.
Reviewers
No reviewers
mlncn
Labels
Clear labels   
A11y

Accessibility-related issues

  
Automated Testing

   
Contributable

Issues with work that can (potentially) be contributed back to Drupal or other FLOSS projects.

  
Contributed

Tag issues where we have contributed work back to FLOSS projects (replace Contributable tag; the Contributed tag can be removed once the contribution is recorded in a blog or something.

  
Decision

An issue that requires a decision be made.

  
Design

Issues that should include a UX/design work or review.

  
Development

   
Drutopia

Issues related to Drutopia features or infrastructure, or are potential Drutopia enhancements (with tag Contributable).

  
Feature Request

   
IndieWeb

Anything related to interlinking web sites in a broadly IndieWeb fashion, see https://indieweb.org/

  
Infrastructure

   
Marketing

   
Needs documentation

When an issue has uncovered something that should be documented in a user guide or the project wiki or anywhere else outside the issue queue.

  
status::Abandoned

An issue that has been abandoned and will not be completed.

  
status::Blocked

An issue that is blocked for a reason outside Agaric's control.

  
status::Deploy

An issue that has been tested and is ready to be deployed.

  
status::Doing

   
status::Done

   
status::In Review

An issue that has been completed and is ready for a code and/or design review.

  
status::Needs Clarification

   
status::Test

An issue that has been completed and is ready to be tested.

  
status::To Do

An issue that is an agreed priority and has all information needed to be completed.

  
type::Bug

   
type::Task

   
type::User Story
No labels
A11y
Automated Testing
Contributable
Contributed
Decision
Design
Development
Drutopia
Feature Request
IndieWeb
Infrastructure
Marketing
Needs documentation
status::Abandoned
status::Blocked
status::Deploy
status::Doing
status::Done
status::In Review
status::Needs Clarification
status::Test
status::To Do
type::Bug
type::Task
type::User Story
Milestone
Clear milestone
No items
No milestone
Post-Launch
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: agaric/agaric-coop#295
No description provided.
Delete branch "177-open-graph"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?