agaric/agaric-coop
10
1
Fork 0
Code Issues 102 Pull requests Projects Releases Packages Wiki Activity

These changes were made on Live. #303

Merged
gnuget merged 1 commit from live-changes into master 2019-02-05 22:55:16 +00:00
Conversation 30 Commits 1 Files changed 107 +193 -113
gnuget commented 2019-02-04 19:29:21 +00:00 (Migrated from gitlab.com)
Copy link
No description provided.
cedewey (Migrated from gitlab.com) approved these changes 2019-02-04 19:29:21 +00:00
gnuget commented 2019-02-04 19:34:26 +00:00 (Migrated from gitlab.com)
Copy link

changed title from Th{-is-} changes were made on Live. to Th{+ese+} changes were made on Live.

changed title from **Th{-is-} changes were made on Live.** to **Th{+ese+} changes were made on Live.**
gnuget commented 2019-02-04 19:52:37 +00:00 (Migrated from gitlab.com)
Copy link

marked as a Work In Progress

marked as a **Work In Progress**
mlncn commented 2019-02-04 19:54:47 +00:00 (Migrated from gitlab.com)
Copy link

@gnuget i don't think the config snapshot changes should be committed- as a rule, but in this case in particular. Deletions probably mean these modules were enabled locally and will be enabled when deployed?

@gnuget i don't think the config snapshot changes should be committed- as a rule, but in this case in particular. Deletions probably mean these modules were enabled locally and will be enabled when deployed?
gnuget commented 2019-02-04 19:56:52 +00:00 (Migrated from gitlab.com)
Copy link

This shouldn't be removed, right @cedewey?

This shouldn't be removed, right @cedewey?
mlncn commented 2019-02-04 19:56:58 +00:00 (Migrated from gitlab.com)
Copy link

pretty sure everything in this file shouldn't be committed either; it likely is undoing my reversion of what never should have been committed in the first place— e62965946d

pretty sure everything in this file shouldn't be committed either; it likely is undoing my reversion of what never should have been committed in the first place— https://gitlab.com/agaric/sites/agaric-com/commit/e62965946d659e09da4aab66ec2d7c9de69b0d40
mlncn commented 2019-02-04 19:57:09 +00:00 (Migrated from gitlab.com)
Copy link

^^ @gnuget

^^ @gnuget
cedewey commented 2019-02-04 20:04:35 +00:00 (Migrated from gitlab.com)
Copy link

Correct, those should not be removed.

Correct, those should not be removed.
mlncn commented 2019-02-05 03:24:22 +00:00 (Migrated from gitlab.com)
Copy link

@gnuget here's where it gets changed, whoever did it!

@gnuget here's where it gets changed, whoever did it!
mlncn commented 2019-02-05 03:26:48 +00:00 (Migrated from gitlab.com)
Copy link

@gnuget another over-eager translation we'll blame on @cedewey

@gnuget another over-eager translation we'll blame on @cedewey
mlncn commented 2019-02-05 03:27:37 +00:00 (Migrated from gitlab.com)
Copy link

This too should revert back. ("Body" field sounds weird enough in English; how weird does "Cuerpo" sound in Spanish?)

This too should revert back. ("Body" field sounds weird enough in English; how weird does "Cuerpo" sound in Spanish?)
mlncn commented 2019-02-05 03:30:39 +00:00 (Migrated from gitlab.com)
Copy link

@gnuget @cedewey want to run by me one more time what language_alterable means in the context of language content settings for a paragraph?

@gnuget @cedewey want to run by me one more time what language_alterable means in the context of language content settings for a paragraph?
mlncn commented 2019-02-05 03:32:55 +00:00 (Migrated from gitlab.com)
Copy link

@gnuget We don't want to remove any of this from configuration; these were intentionally committed in @cedewey's recent merge request.

@gnuget We don't want to remove any of this from configuration; these were intentionally committed in @cedewey's recent merge request.
mlncn commented 2019-02-05 03:33:32 +00:00 (Migrated from gitlab.com)
Copy link

@gnuget likewise, don't want this overridden here like this.

@gnuget likewise, don't want this overridden here like this.
mlncn commented 2019-02-05 03:34:40 +00:00 (Migrated from gitlab.com)
Copy link

@gnuget and presumably @cedewey did mean to get rid of these defaults, as they are now covered by global and by more specific?

@gnuget and presumably @cedewey did mean to get rid of these defaults, as they are now covered by global and by more specific?
mlncn commented 2019-02-05 03:35:17 +00:00 (Migrated from gitlab.com)
Copy link

@gnuget OK you've already covered this with Clayton :-)

@gnuget OK you've already covered this with Clayton :-)
gnuget commented 2019-02-05 19:42:36 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/sites/agaric-com/merge_requests/60/diffs?diff_id=33313738&start_sha=e731bc3bbbe5ae286d81a0d3e7a553510e53ee3b#66aaad861652c5a42429e86cbe059ce054d61df2_13_13)
gnuget commented 2019-02-05 19:42:37 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/sites/agaric-com/merge_requests/60/diffs?diff_id=33313738&start_sha=e731bc3bbbe5ae286d81a0d3e7a553510e53ee3b#413588541a38cecd55204e11f5bc7b13114e80fe_6_6)
gnuget commented 2019-02-05 19:42:37 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/sites/agaric-com/merge_requests/60/diffs?diff_id=33313738&start_sha=e731bc3bbbe5ae286d81a0d3e7a553510e53ee3b#6c806504ae0be48be785ca2d30dfb3361fe6b956_16_15)
gnuget commented 2019-02-05 19:42:38 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/sites/agaric-com/merge_requests/60/diffs?diff_id=33313738&start_sha=e731bc3bbbe5ae286d81a0d3e7a553510e53ee3b#441b4b64a364234bfc264b096c9601b6341a88f0_15_14)
gnuget commented 2019-02-05 19:42:38 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/sites/agaric-com/merge_requests/60/diffs?diff_id=33313738&start_sha=e731bc3bbbe5ae286d81a0d3e7a553510e53ee3b#acd81f1e5ae1869a8738cad51e547fcf41c34c86_17_16)
gnuget commented 2019-02-05 19:42:39 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/sites/agaric-com/merge_requests/60/diffs?diff_id=33313738&start_sha=e731bc3bbbe5ae286d81a0d3e7a553510e53ee3b)
gnuget commented 2019-02-05 19:42:39 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/sites/agaric-com/merge_requests/60/diffs?diff_id=33313738&start_sha=e731bc3bbbe5ae286d81a0d3e7a553510e53ee3b)
gnuget commented 2019-02-05 19:42:39 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/sites/agaric-com/merge_requests/60/diffs?diff_id=33313738&start_sha=e731bc3bbbe5ae286d81a0d3e7a553510e53ee3b#78fec60c6bc3b8507eceaf5708f1b2413a3337f8_13_13)
gnuget commented 2019-02-05 19:42:40 +00:00 (Migrated from gitlab.com)
Copy link

added 2 commits

  • b9cf9bbd - Revert "This changes were made on Live."
  • 45f7f228 - The metatag changes were restored.

Compare with previous version

added 2 commits <ul><li>b9cf9bbd - Revert &quot;This changes were made on Live.&quot;</li><li>45f7f228 - The metatag changes were restored.</li></ul> [Compare with previous version](https://gitlab.com/agaric/sites/agaric-com/merge_requests/60/diffs?diff_id=33313738&start_sha=e731bc3bbbe5ae286d81a0d3e7a553510e53ee3b)
gnuget commented 2019-02-05 19:44:04 +00:00 (Migrated from gitlab.com)
Copy link

unmarked as a Work In Progress

unmarked as a **Work In Progress**
cedewey commented 2019-02-05 22:54:44 +00:00 (Migrated from gitlab.com)
Copy link

This states that each paragraph is now translatable, as recommended in the Paragraphs documentation.

This states that each paragraph is now translatable, as recommended in the Paragraphs documentation.
cedewey commented 2019-02-05 22:54:45 +00:00 (Migrated from gitlab.com)
Copy link

resolved all discussions

resolved all discussions
cedewey commented 2019-02-05 22:55:10 +00:00 (Migrated from gitlab.com)
Copy link

approved this merge request

approved this merge request
cedewey commented 2019-02-05 22:55:16 +00:00 (Migrated from gitlab.com)
Copy link

merged

merged
cedewey commented 2019-02-05 22:55:17 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit bc35f0d2ba

mentioned in commit bc35f0d2bae91dddfe5acb7bd9cf37a342ae4ed5
Sign in to join this conversation.
Reviewers
No reviewers
cedewey
Labels
Clear labels   
A11y

Accessibility-related issues

  
Automated Testing

   
Contributable

Issues with work that can (potentially) be contributed back to Drupal or other FLOSS projects.

  
Contributed

Tag issues where we have contributed work back to FLOSS projects (replace Contributable tag; the Contributed tag can be removed once the contribution is recorded in a blog or something.

  
Decision

An issue that requires a decision be made.

  
Design

Issues that should include a UX/design work or review.

  
Development

   
Drutopia

Issues related to Drutopia features or infrastructure, or are potential Drutopia enhancements (with tag Contributable).

  
Feature Request

   
IndieWeb

Anything related to interlinking web sites in a broadly IndieWeb fashion, see https://indieweb.org/

  
Infrastructure

   
Marketing

   
Needs documentation

When an issue has uncovered something that should be documented in a user guide or the project wiki or anywhere else outside the issue queue.

  
status::Abandoned

An issue that has been abandoned and will not be completed.

  
status::Blocked

An issue that is blocked for a reason outside Agaric's control.

  
status::Deploy

An issue that has been tested and is ready to be deployed.

  
status::Doing

   
status::Done

   
status::In Review

An issue that has been completed and is ready for a code and/or design review.

  
status::Needs Clarification

   
status::Test

An issue that has been completed and is ready to be tested.

  
status::To Do

An issue that is an agreed priority and has all information needed to be completed.

  
type::Bug

   
type::Task

   
type::User Story
No labels
A11y
Automated Testing
Contributable
Contributed
Decision
Design
Development
Drutopia
Feature Request
IndieWeb
Infrastructure
Marketing
Needs documentation
status::Abandoned
status::Blocked
status::Deploy
status::Doing
status::Done
status::In Review
status::Needs Clarification
status::Test
status::To Do
type::Bug
type::Task
type::User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: agaric/agaric-coop#303
No description provided.
Delete branch "live-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?