agaric/patternlibrary
10
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Make the whole top header fixed #5

Merged
cedewey merged 0 commits from 81-integrate-styleguide into master 2018-09-25 16:53:09 +00:00
Conversation 14 Commits - Files changed -
cedewey commented 2018-09-07 20:31:44 +00:00 (Migrated from gitlab.com)
Copy link
No description provided.
mlncn (Migrated from gitlab.com) approved these changes 2018-09-07 20:31:44 +00:00
mlncn commented 2018-09-07 20:47:15 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey You can apply this class directly to the <nav> element (and if not doing that, everything inside the new <div> should be indented another two spaces.

@cedewey You can apply this class directly to the `<nav>` element (and if not doing that, everything inside the new `<div>` should be indented another two spaces.
cedewey commented 2018-09-07 21:42:13 +00:00 (Migrated from gitlab.com)
Copy link

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](https://gitlab.com/agaric/patternlibrary/merge_requests/2/diffs?diff_id=22642944&start_sha=e6c16af9ccece1cd17b2cf0d3e61b4485fb356fc#0a27d616ceb661038deb6531a811a41d7dbe1a23_7_7)
cedewey commented 2018-09-07 21:42:14 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 4275c608 - Add indentation to elements in div

Compare with previous version

added 1 commit <ul><li>4275c608 - Add indentation to elements in div</li></ul> [Compare with previous version](https://gitlab.com/agaric/patternlibrary/merge_requests/2/diffs?diff_id=22642944&start_sha=e6c16af9ccece1cd17b2cf0d3e61b4485fb356fc)
cedewey commented 2018-09-07 21:44:14 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

Compare with previous version

added 1 commit <ul><li>dbdb3a9b - Indentation, but properly</li></ul> [Compare with previous version](https://gitlab.com/agaric/patternlibrary/merge_requests/2/diffs?diff_id=22642977&start_sha=4275c608ea5272d5e6e49a49c2f270b94a606735)
cedewey commented 2018-09-07 21:45:22 +00:00 (Migrated from gitlab.com)
Copy link

@mlncn we need the div since there are two navs. I've fixed the indentation.

@mlncn we need the div since there are two navs. I've fixed the indentation.
cedewey commented 2018-09-07 21:58:55 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 509dd6fe - Add navbar classes specific to Agaric menu block

Compare with previous version

added 1 commit <ul><li>509dd6fe - Add navbar classes specific to Agaric menu block</li></ul> [Compare with previous version](https://gitlab.com/agaric/patternlibrary/merge_requests/2/diffs?diff_id=22643273&start_sha=dbdb3a9bce793a87e28b7048dc3956b1da4d1213)
cedewey commented 2018-09-17 21:06:21 +00:00 (Migrated from gitlab.com)
Copy link

added 6 commits

  • af97d74f - Add transparent navbar class to header
  • afa699bd - Add header image to Agarica theme and set background image for homepage
  • e9da2d89 - Change to front page template
  • 9f673cf3 - Add is-2 class to site slogan
  • e8a620ab - Remove main section from homepage
  • ef7488b3 - Customize slide to match Agaric styles

Compare with previous version

added 6 commits <ul><li>af97d74f - Add transparent navbar class to header</li><li>afa699bd - Add header image to Agarica theme and set background image for homepage</li><li>e9da2d89 - Change to front page template</li><li>9f673cf3 - Add is-2 class to site slogan</li><li>e8a620ab - Remove main section from homepage</li><li>ef7488b3 - Customize slide to match Agaric styles</li></ul> [Compare with previous version](https://gitlab.com/agaric/patternlibrary/merge_requests/2/diffs?diff_id=23323644&start_sha=509dd6fe3ce6f0e79febb61a8e9de279b809457e)
cedewey commented 2018-09-17 21:08:48 +00:00 (Migrated from gitlab.com)
Copy link

@mlncn ok, I've updated the slide style on the homepage. I looked through the styleguide and the homepage is the only place this slide is used. In fact this one single slide is the only slide on the homepage, making it the only slide on the site.

There are other "slides" but they are defined by Todd as cards.

This is my justification for a somewhat heavy-handed approach to this. Lots of classes directly in the template, overriding both Octavia and Bulma templates.

Anyways, looking forward to the review and possible critiques. :)

@mlncn ok, I've updated the slide style on the homepage. I looked through the styleguide and the homepage is the only place this slide is used. In fact this one single slide is the only slide on the homepage, making it the only slide on the site. There are other "slides" but they are defined by Todd as cards. This is my justification for a somewhat heavy-handed approach to this. Lots of classes directly in the template, overriding both Octavia and Bulma templates. Anyways, looking forward to the review and possible critiques. :)
mlncn commented 2018-09-18 02:00:51 +00:00 (Migrated from gitlab.com)
Copy link

Narrator: There were not in fact two navs, but our protagonists realized that there were more important things in life.

Narrator: There were not in fact two `nav`s, but our protagonists realized that there were more important things in life.
mlncn commented 2018-09-18 02:00:52 +00:00 (Migrated from gitlab.com)
Copy link

resolved all discussions

resolved all discussions
mlncn commented 2018-09-18 02:01:51 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey all the images are already committed to the pattern library so i wouldn't expect to see new additions here— moving, maybe, but most likely referencing them where they are.

@cedewey all the images are already committed to the pattern library so i wouldn't expect to see new additions here— moving, maybe, but most likely referencing them where they are.
mlncn commented 2018-09-18 07:27:06 +00:00 (Migrated from gitlab.com)
Copy link

approved this merge request

approved this merge request
mlncn commented 2018-09-25 16:53:09 +00:00 (Migrated from gitlab.com)
Copy link

merged

merged
mlncn commented 2018-09-25 16:53:09 +00:00 (Migrated from gitlab.com)
Copy link

mentioned in commit 0fa12f27ef

mentioned in commit 0fa12f27ef1c7350a45b2e2dcfe6d39b4ab2c266
Sign in to join this conversation.
Reviewers
No reviewers
mlncn
Labels
Clear labels   
A11y

Accessibility-related issues

  
Automated Testing

   
Bug

   
Contributable

Issues with work that can (potentially) be contributed back to Drupal or other FLOSS projects.

  
Contributed

Tag issues where we have contributed work back to FLOSS projects (replace Contributable tag; the Contributed tag can be removed once the contribution is recorded in a blog or something.

  
Decision

An issue that requires a decision be made.

  
Design

Issues that should include a UX/design work or review.

  
Development

   
Drutopia

Issues related to Drutopia features or infrastructure, or are potential Drutopia enhancements (with tag Contributable).

  
IndieWeb

Anything related to interlinking web sites in a broadly IndieWeb fashion, see https://indieweb.org/

  
Infrastructure

   
Marketing

   
Needs documentation

When an issue has uncovered something that should be documented in a user guide or the project wiki or anywhere else outside the issue queue.

  
status::Abandoned

An issue that has been abandoned and will not be completed.

  
status::Blocked

An issue that is blocked for a reason outside Agaric's control.

  
status::Deploy

An issue that has been tested and is ready to be deployed.

  
status::Doing

   
status::Done

   
status::In Review

An issue that has been completed and is ready for a code and/or design review.

  
status::Needs Clarification

   
status::Test

An issue that has been completed and is ready to be tested.

  
status::To Do

An issue that is an agreed priority and has all information needed to be completed.

  
type::Bug

   
type::Task

   
type::User Story
No labels
A11y
Automated Testing
Bug
Contributable
Contributed
Decision
Design
Development
Drutopia
IndieWeb
Infrastructure
Marketing
Needs documentation
status::Abandoned
status::Blocked
status::Deploy
status::Doing
status::Done
status::In Review
status::Needs Clarification
status::Test
status::To Do
type::Bug
type::Task
type::User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: agaric/patternlibrary#5
No description provided.
Delete branch "81-integrate-styleguide"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?