geo/geo-coop
geo/geo-coop
7
1
Fork 0
Code Issues 55 Pull requests Projects Releases Packages Wiki Activity Actions

"Restore better, built-in comment functionality to the site" #131

Closed
cedewey wants to merge 4 commits from 12-comments into master
pull from: 12-comments
merge into: geo:master
Conversation 9 Commits 4 Files changed 12 +82 -49
cedewey commented 2019-08-31 19:48:24 +00:00 (Migrated from gitlab.com)
Copy link
No description provided.
mlncn commented 2019-09-01 01:59:58 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey did you intentionally take away "Use exclude node title" permissions? If so, are you ware that's needed for the title to be hidden in the circumstances in which it should be hidden? But i'm not sure where we're trying to exclude it; that's why i ask. But pretty sure Drutopia does somewhere to give Display Suite all the power.

@cedewey did you intentionally take away "Use exclude node title" permissions? If so, are you ware that's [needed](https://www.drupal.org/project/exclude_node_title/issues/2865844) for the title to be hidden in the circumstances in which it should be hidden? But i'm not sure where we're trying to exclude it; that's why i ask. But pretty sure Drutopia does somewhere to give Display Suite all the power.
mlncn commented 2019-09-01 02:07:53 +00:00 (Migrated from gitlab.com)
Copy link

@cedewey and for the hierarchical select, i'm fairly sure we want 'force_deepest' to be true; we want only the most specific terms to be matched to the nodes, not the (edit: larger) categories, yes?

@cedewey and for the hierarchical select, i'm fairly sure we want 'force_deepest' to be true; we want only the most specific terms to be matched to the nodes, not the (edit: larger) categories, yes?
cedewey commented 2019-09-02 14:48:01 +00:00 (Migrated from gitlab.com)
Copy link

added 1 commit

  • 5562b772 - Restore 'exclude node title' permission

Compare with previous version

added 1 commit <ul><li>5562b772 - Restore &#39;exclude node title&#39; permission</li></ul> [Compare with previous version](/agaric/sites/geo/merge_requests/3/diffs?diff_id=53397995&start_sha=287ee8f4c0aaf38aa6427995ae48454d45edc970)
cedewey commented 2019-09-02 14:48:56 +00:00 (Migrated from gitlab.com)
Copy link

No, that was not intentional. Sorry about that. I will more diligently review these config changes to avoid errant unintentional changes.

No, that was not intentional. Sorry about that. I will more diligently review these config changes to avoid errant unintentional changes.
mlncn commented 2019-09-23 00:40:51 +00:00 (Migrated from gitlab.com)
Copy link

And there should not be comments on pages and landing pages.

And there should not be comments on pages and landing pages.
mlncn commented 2019-09-23 00:42:00 +00:00 (Migrated from gitlab.com)
Copy link

and this seems to be an unintentional removal?

and this seems to be an unintentional removal?
mlncn commented 2019-09-23 00:43:17 +00:00 (Migrated from gitlab.com)
Copy link

this is still here...

this is still here...
mlncn commented 2019-09-23 00:43:35 +00:00 (Migrated from gitlab.com)
Copy link

too messy to be brought in, sorry.

too messy to be brought in, sorry.
mlncn commented 2019-09-23 00:43:35 +00:00 (Migrated from gitlab.com)
Copy link

closed

closed

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
A11y

Accessibility-related issues

  
Automated Testing

   
Contributable

Issues with work that can (potentially) be contributed back to Drupal or other FLOSS projects.

  
Contributed

Tag issues where we have contributed work back to FLOSS projects (replace Contributable tag; the Contributed tag can be removed once the contribution is recorded in a blog or something.

  
Decision

An issue that requires a decision be made.

  
Design

Issues that should include a UX/design work or review.

  
Development

   
Drutopia

Issues related to Drutopia features or infrastructure, or are potential Drutopia enhancements (with tag Contributable).

  
IndieWeb

Anything related to interlinking web sites in a broadly IndieWeb fashion, see https://indieweb.org/

  
Infrastructure

   
Launch Critical

Issue that must be done in time for launch.

  
Marketing

   
Needs documentation

When an issue has uncovered something that should be documented in a user guide or the project wiki or anywhere else outside the issue queue.

  
Post-Launch

An issue that needs to be completed, but can happen after launch.

  
status
Abandoned
An issue that has been abandoned and will not be completed.

  
status
Blocked
An issue that is blocked for a reason outside Agaric's control.

  
status
Deploy
An issue that has been tested and is ready to be deployed.

  
status
Doing

  
status
Done

  
status
In Review
An issue that has been completed and is ready for a code and/or design review.

  
status
Needs Clarification

  
status
Test
An issue that has been completed and is ready to be tested.

  
status
To Do
An issue that is an agreed priority and has all information needed to be completed.

  
type
Bug

  
type
Task

  
type
User Story

No labels
A11y
Automated Testing
Contributable
Contributed
Decision
Design
Development
Drutopia
IndieWeb
Infrastructure
Launch Critical
Marketing
Needs documentation
Post-Launch
status
Abandoned
status
Blocked
status
Deploy
status
Doing
status
Done
status
In Review
status
Needs Clarification
status
Test
status
To Do
type
Bug
type
Task
type
User Story
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: geo/geo-coop#131
No description provided.
Delete branch "12-comments"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?