geo/geo-coop
geo/geo-coop
7
1
Fork 0
Code Issues54 Pull requests Projects Releases Packages Wiki Activity Actions

A content editor chooses the child term of a parent item in its own field. #15

New issue
Closed
opened 2019-07-27 21:10:51 +00:00 by mlncn · 31 comments
mlncn commented 2019-07-27 21:10:51 +00:00 (Migrated from gitlab.com)

Acceptance Criteria

Given that I am a content editor,
when I create an article, blog, page or gleaning,
then I can enter terms for each parent topic,
so that I can easily tag content with the appropriate terms.

Background

We decided that it'd be best for several vocabularies to be combined into the Topics vocabulary.

Work Required

  • Add the Client-side Hierarchical Select module to the project
  • Configure the appropriate topic reference fields to use the CSHS-provided widget.
## Acceptance Criteria Given that I am a content editor, when I create an article, blog, page or gleaning, then I can enter terms for each parent topic, so that I can easily tag content with the appropriate terms. ## Background We decided that it'd be best for several vocabularies to be combined into the Topics vocabulary. ## Work Required * [x] Add the Client-side Hierarchical Select module to the project * [x] Configure the appropriate topic reference fields to use the CSHS-provided widget.
mlncn commented 2019-07-27 21:11:49 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
mlncn commented 2019-07-27 21:13:03 +00:00 (Migrated from gitlab.com)

marked this issue as related to

marked this issue as related to #5
cedewey commented 2019-07-28 21:02:44 +00:00 (Migrated from gitlab.com)

@mlncn have you confirmed this with Josh? When I talked with him we
decided to keep all those vocabularies as is - separate with the same
names and terms.

I haven't found that widget yet.

@mlncn have you confirmed this with Josh? When I talked with him we decided to keep all those vocabularies as is - separate with the same names and terms. I haven't found that widget yet.
mlncn commented 2019-07-29 19:22:57 +00:00 (Migrated from gitlab.com)

@cedewey https://www.drupal.org/project/cshs and https://www.drupal.org/project/shs are the two contenders for D8, can you do a UX review?

A hierarchical vocabulary will be functionally indistinguishable from separate vocabularies, but it will make it possible to reorganize at a future date without another migration.

@cedewey https://www.drupal.org/project/cshs and https://www.drupal.org/project/shs are the two contenders for D8, can you do a UX review? A hierarchical vocabulary will be functionally indistinguishable from separate vocabularies, but it will make it possible to reorganize at a future date without another migration.
gnuget commented 2019-08-02 18:02:23 +00:00 (Migrated from gitlab.com)

The only thing missing here is to determine if we are going to use cshs or shs.

All the part related with the migration is done :-)

The only thing missing here is to determine if we are going to use `cshs` or `shs`. All the part related with the migration is done :-)
gnuget commented 2019-08-02 18:02:34 +00:00 (Migrated from gitlab.com)

assigned to @cedewey and unassigned @gnuget

assigned to @cedewey and unassigned @gnuget
cedewey commented 2019-08-20 15:46:44 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
cedewey commented 2019-08-20 16:09:44 +00:00 (Migrated from gitlab.com)

@gnuget some terms migrated over successfully but not all.

  • Economic Sectors - missing Mutual Aid
  • Institutions & Structures - missing all child terms
  • Movements & Struggles - missing all child terms
  • Pratices, Tools & Strategies - missing all child terms
  • Visions & Models - missing all child terms

Here is the output on the command line when I ran the migration.

 [notice] Processed 443 items (443 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_node_story_author'
 [notice] Processed 4906 items (4791 created, 0 updated, 0 failed, 115 ignored) - done with 'upgrade_d7_url_alias'
 [notice] Processed 6 items (6 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_user_role'
 [notice] Processed 4124 items (4121 created, 0 updated, 3 failed, 0 ignored) - done with 'upgrade_d7_file'

In MigrateToolsCommands.php line 811:
                                         
  upgrade_d7_file Migration - 3 failed.  
                                         

migrate:import [--all] [--group GROUP] [--tag TAG] [--limit LIMIT] [--feedback FEEDBACK] [--idlist IDLIST] [--idlist-delimiter [IDLIST-DELIMITER]] [--update] [--force] [--execute-dependencies] [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-d|--debug] [-y|--yes] [--no] [--remote-host REMOTE-HOST] [--remote-user REMOTE-USER] [-r|--root ROOT] [-l|--uri URI] [--simulate] [--pipe] [-D|--define DEFINE] [--xh-link XH-LINK] [--druplicon] [--notify] [--] <command> [<migration_names>]

Failed to execute command drush mim --group=migrate_drupal_7_geo: exit status 1 
clayton@ClaytonThinkPad:~/Projects/agaric/sites/geo/web$ ddev . drush mim --group="migrate_drupal_7_geo"
 [notice] Processed 2 items (2 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_node_story_author'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_url_alias'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_user_role'
 [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_file'
 [notice] Field discovery failed for Drupal core version 7. Did this site have the CCK or Field module installed? Error: No database connection configured for source plugin d7_field_instance
 [notice] Processed 121 items (121 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_user'
 [notice] Processed 38 items (38 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_node_page_body_paragraph'
 [notice] Processed 38 items (38 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_node_page'
 [notice] Processed 17 items (6 created, 0 updated, 0 failed, 11 ignored) - done with 'upgrade_d7_taxonomy_vocabulary'
 [error]  Drupal\Core\Database\IntegrityConstraintViolationException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'vid' cannot be null: UPDATE {taxonomy_term_data} SET revision_id=:db_update_placeholder_0, vid=:db_update_placeholder_1, uuid=:db_update_placeholder_2, langcode=:db_update_placeholder_3
WHERE tid = :db_condition_placeholder_0; Array
(
    [:db_update_placeholder_0] => 5
    [:db_update_placeholder_1] => 
    [:db_update_placeholder_2] => f6de2465-6f28-401a-b7f7-aa90ce9f5070
    [:db_update_placeholder_3] => en
    [:db_condition_placeholder_0] => 5
)
 in Drupal\Core\Database\Connection->handleQueryException() (line 689 of /var/www/html/web/core/lib/Drupal/Core/Database/Connection.php). 
 [error]  SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'vid' cannot be null: UPDATE {taxonomy_term_data} SET revision_id=:db_update_placeholder_0, vid=:db_update_placeholder_1, uuid=:db_update_placeholder_2, langcode=:db_update_placeholder_3
WHERE tid = :db_condition_placeholder_0; Array
(
    [:db_update_placeholder_0] => 5
    [:db_update_placeholder_1] => 
    [:db_update_placeholder_2] => f6de2465-6f28-401a-b7f7-aa90ce9f5070
    [:db_update_placeholder_3] => en
    [:db_condition_placeholder_0] => 5
)
 (/var/www/html/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php:847) 
 [notice] Processed 33 items (32 created, 0 updated, 1 failed, 0 ignored) - done with 'upgrade_d7_taxonomy_term_vocabulary_1'

In MigrateToolsCommands.php line 811:
                                                               
  upgrade_d7_taxonomy_term_vocabulary_1 Migration - 1 failed.  
                                                               

migrate:import [--all] [--group GROUP] [--tag TAG] [--limit LIMIT] [--feedback FEEDBACK] [--idlist IDLIST] [--idlist-delimiter [IDLIST-DELIMITER]] [--update] [--force] [--execute-dependencies] [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-d|--debug] [-y|--yes] [--no] [--remote-host REMOTE-HOST] [--remote-user REMOTE-USER] [-r|--root ROOT] [-l|--uri URI] [--simulate] [--pipe] [-D|--define DEFINE] [--xh-link XH-LINK] [--druplicon] [--notify [NOTIFY]] [--] <command> [<migration_names>]

Failed to execute command drush mim --group=migrate_drupal_7_geo: exit status 1
@gnuget some terms migrated over successfully but not all. * Economic Sectors - missing _Mutual Aid_ * Institutions & Structures - missing all child terms * Movements & Struggles - missing all child terms * Pratices, Tools & Strategies - missing all child terms * Visions & Models - missing all child terms Here is the output on the command line when I ran the migration. ``` [notice] Processed 443 items (443 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_node_story_author' [notice] Processed 4906 items (4791 created, 0 updated, 0 failed, 115 ignored) - done with 'upgrade_d7_url_alias' [notice] Processed 6 items (6 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_user_role' [notice] Processed 4124 items (4121 created, 0 updated, 3 failed, 0 ignored) - done with 'upgrade_d7_file' In MigrateToolsCommands.php line 811: upgrade_d7_file Migration - 3 failed. migrate:import [--all] [--group GROUP] [--tag TAG] [--limit LIMIT] [--feedback FEEDBACK] [--idlist IDLIST] [--idlist-delimiter [IDLIST-DELIMITER]] [--update] [--force] [--execute-dependencies] [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-d|--debug] [-y|--yes] [--no] [--remote-host REMOTE-HOST] [--remote-user REMOTE-USER] [-r|--root ROOT] [-l|--uri URI] [--simulate] [--pipe] [-D|--define DEFINE] [--xh-link XH-LINK] [--druplicon] [--notify] [--] <command> [<migration_names>] Failed to execute command drush mim --group=migrate_drupal_7_geo: exit status 1 clayton@ClaytonThinkPad:~/Projects/agaric/sites/geo/web$ ddev . drush mim --group="migrate_drupal_7_geo" [notice] Processed 2 items (2 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_node_story_author' [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_url_alias' [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_user_role' [notice] Processed 0 items (0 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_file' [notice] Field discovery failed for Drupal core version 7. Did this site have the CCK or Field module installed? Error: No database connection configured for source plugin d7_field_instance [notice] Processed 121 items (121 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_user' [notice] Processed 38 items (38 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_node_page_body_paragraph' [notice] Processed 38 items (38 created, 0 updated, 0 failed, 0 ignored) - done with 'upgrade_d7_node_page' [notice] Processed 17 items (6 created, 0 updated, 0 failed, 11 ignored) - done with 'upgrade_d7_taxonomy_vocabulary' [error] Drupal\Core\Database\IntegrityConstraintViolationException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'vid' cannot be null: UPDATE {taxonomy_term_data} SET revision_id=:db_update_placeholder_0, vid=:db_update_placeholder_1, uuid=:db_update_placeholder_2, langcode=:db_update_placeholder_3 WHERE tid = :db_condition_placeholder_0; Array ( [:db_update_placeholder_0] => 5 [:db_update_placeholder_1] => [:db_update_placeholder_2] => f6de2465-6f28-401a-b7f7-aa90ce9f5070 [:db_update_placeholder_3] => en [:db_condition_placeholder_0] => 5 ) in Drupal\Core\Database\Connection->handleQueryException() (line 689 of /var/www/html/web/core/lib/Drupal/Core/Database/Connection.php). [error] SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'vid' cannot be null: UPDATE {taxonomy_term_data} SET revision_id=:db_update_placeholder_0, vid=:db_update_placeholder_1, uuid=:db_update_placeholder_2, langcode=:db_update_placeholder_3 WHERE tid = :db_condition_placeholder_0; Array ( [:db_update_placeholder_0] => 5 [:db_update_placeholder_1] => [:db_update_placeholder_2] => f6de2465-6f28-401a-b7f7-aa90ce9f5070 [:db_update_placeholder_3] => en [:db_condition_placeholder_0] => 5 ) (/var/www/html/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php:847) [notice] Processed 33 items (32 created, 0 updated, 1 failed, 0 ignored) - done with 'upgrade_d7_taxonomy_term_vocabulary_1' In MigrateToolsCommands.php line 811: upgrade_d7_taxonomy_term_vocabulary_1 Migration - 1 failed. migrate:import [--all] [--group GROUP] [--tag TAG] [--limit LIMIT] [--feedback FEEDBACK] [--idlist IDLIST] [--idlist-delimiter [IDLIST-DELIMITER]] [--update] [--force] [--execute-dependencies] [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-d|--debug] [-y|--yes] [--no] [--remote-host REMOTE-HOST] [--remote-user REMOTE-USER] [-r|--root ROOT] [-l|--uri URI] [--simulate] [--pipe] [-D|--define DEFINE] [--xh-link XH-LINK] [--druplicon] [--notify [NOTIFY]] [--] <command> [<migration_names>] Failed to execute command drush mim --group=migrate_drupal_7_geo: exit status 1 ```
cedewey commented 2019-08-20 16:09:57 +00:00 (Migrated from gitlab.com)

assigned to @gnuget and unassigned @cedewey

assigned to @gnuget and unassigned @cedewey
cedewey commented 2019-08-20 16:10:50 +00:00 (Migrated from gitlab.com)

@gnuget also, I can just recreate the terms manually if it's going to take awhile to get this fixed in the migration, just let me know. Thanks!

@gnuget also, I can just recreate the terms manually if it's going to take awhile to get this fixed in the migration, just let me know. Thanks!
cedewey commented 2019-08-20 16:38:51 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
cedewey commented 2019-08-20 16:40:31 +00:00 (Migrated from gitlab.com)

CSHS is the only one of the two modules where you can specify a single parent item to associate with a field. For example, the Economic Sectors reference field, having the author only choose child terms of Economic Sectors. So, it's the winner!

CSHS is the only one of the two modules where you can specify a single parent item to associate with a field. For example, the Economic Sectors reference field, having the author only choose child terms of Economic Sectors. So, it's the winner!
cedewey commented 2019-08-20 16:54:50 +00:00 (Migrated from gitlab.com)

mentioned in issue

mentioned in issue #23
cedewey commented 2019-08-20 16:55:09 +00:00 (Migrated from gitlab.com)

changed title from {-Update taxonomy migrations to merge them into the Topic vocabulary as hierarchical-} to {+A caregiver can see a thumbnail map of the location on programs, events, places, and organizations on their respective pages.+}

changed title from **{-Update taxonomy migrations to merge them into the Topic vocabulary as hierarchical-}** to **{+A caregiver can see a thumbnail map of the location on programs, events, places, and organizations on their respective pages.+}**
cedewey commented 2019-08-20 16:55:09 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
cedewey commented 2019-08-20 17:00:14 +00:00 (Migrated from gitlab.com)

changed title from A c{-aregiver can see a thumbnail map of the location on programs, events, places, and organizations on their respective pages-}. to A c{+ontent editor chooses the child term of a parent item in its own field+}.

changed title from **A c{-aregiver can see a thumbnail map of the location on programs, events, places, and organizations on their respective pages-}.** to **A c{+ontent editor chooses the child term of a parent item in its own field+}.**
cedewey commented 2019-08-20 17:00:14 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
cedewey commented 2019-08-20 17:00:25 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
cedewey commented 2019-08-20 17:00:31 +00:00 (Migrated from gitlab.com)

assigned to @cedewey and unassigned @gnuget

assigned to @cedewey and unassigned @gnuget
mlncn commented 2019-08-30 16:31:45 +00:00 (Migrated from gitlab.com)

mentioned in commit 4abc28c597

mentioned in commit 4abc28c5976a88023d287fb09fc972b5982408b8
mlncn commented 2019-08-30 16:32:25 +00:00 (Migrated from gitlab.com)

@cedewey OK Client Side Hierarchical Select is installed and enabled, can you take configuring it for these fields?

Thanks!

@cedewey OK [Client Side Hierarchical Select](https://www.drupal.org/project/cshs) is installed and enabled, can you take configuring it for these fields? Thanks!
cedewey commented 2019-08-31 00:17:18 +00:00 (Migrated from gitlab.com)

marked the checklist item Add the Client-side Hierarchical Select module to the project as completed

marked the checklist item **Add the Client-side Hierarchical Select module to the project** as completed
cedewey commented 2019-08-31 19:00:08 +00:00 (Migrated from gitlab.com)

This is on hold until we can see how Facets will work with the two implementation approaches we're considering.

This is on hold until we can see how Facets will work with the two implementation approaches we're considering.
mlncn commented 2019-09-23 03:18:14 +00:00 (Migrated from gitlab.com)

mentioned in commit dea557d1a1

mentioned in commit dea557d1a16c3525a1bdff5d49823894ac38f435
mlncn commented 2019-09-23 11:16:07 +00:00 (Migrated from gitlab.com)

Facets work beautifully with the lowest-selected items of a hierarchical topics— set client-side hierarchical select to the lowest, and the editor experience is pretty good too.

Now just to ensure that migration gets in there.

@wolcen can you re-run the site install and migration on test, CI, or anywhere (live if need be)
@gnuget can you re-run locally? There's pretty certain to be more to clean up even if https://gitlab.com/agaric/sites/geo/issues/15#note_205902650 is already addressed.

Facets work beautifully with the lowest-selected items of a hierarchical topics— set client-side hierarchical select to the lowest, and the editor experience is pretty good too. Now just to ensure that migration gets in there. @wolcen can you re-run the site install and migration on test, CI, or anywhere (live if need be) @gnuget can you re-run locally? There's pretty certain to be more to clean up even if https://gitlab.com/agaric/sites/geo/issues/15#note_205902650 is already addressed.
cedewey commented 2019-09-30 16:08:50 +00:00 (Migrated from gitlab.com)

Closing this and creating a separate migration task.

Closing this and creating a separate migration task.
cedewey commented 2019-09-30 16:08:50 +00:00 (Migrated from gitlab.com)

closed

closed
cedewey commented 2019-09-30 16:09:11 +00:00 (Migrated from gitlab.com)

marked the checklist item Configure the appropriate topic reference fields to use the CSHS-provided widget. as completed

marked the checklist item **Configure the appropriate topic reference fields to use the CSHS-provided widget.** as completed
cedewey commented 2019-09-30 16:16:07 +00:00 (Migrated from gitlab.com)

mentioned in issue

mentioned in issue #48
mlncn commented 2019-10-10 07:24:49 +00:00 (Migrated from gitlab.com)

marked this issue as related to

marked this issue as related to #86
mlncn commented 2019-10-10 07:26:10 +00:00 (Migrated from gitlab.com)

mentioned in issue

mentioned in issue drutopia/drutopia#279
Sign in to join this conversation.
No labels
A11y
Automated Testing
Contributable
Contributed
Decision
Design
Development
Drutopia
IndieWeb
Infrastructure
Launch Critical
Marketing
Needs documentation
Post-Launch
status
Abandoned
status
Blocked
status
Deploy
status
Doing
status
Done
status
In Review
status
Needs Clarification
status
Test
status
To Do
type
Bug
type
Task
type
User Story
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: geo/geo-coop#15
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?